Skip to content

Commit 7669151

Browse files
matttbegregkh
authored andcommitted
selftests: mptcp: join: validate fullmesh endp on 1st sf
commit 4878f9f upstream. This case was not covered, and the wrong ID was set before the previous commit. The rest is not modified, it is just that it will increase the code coverage. The right address ID can be verified by looking at the packet traces. We could automate that using Netfilter with some cBPF code for example, but that's always a bit cryptic. Packetdrill seems better fitted for that. Fixes: 4f49d63 ("selftests: mptcp: add fullmesh testcases") Cc: stable@vger.kernel.org Reviewed-by: Mat Martineau <martineau@kernel.org> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Link: https://patch.msgid.link/20240819-net-mptcp-pm-reusing-id-v1-13-38035d40de5b@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 0201d65 commit 7669151

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

tools/testing/selftests/net/mptcp/mptcp_join.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3058,6 +3058,7 @@ fullmesh_tests()
30583058
pm_nl_set_limits $ns1 1 3
30593059
pm_nl_set_limits $ns2 1 3
30603060
pm_nl_add_endpoint $ns1 10.0.2.1 flags signal
3061+
pm_nl_add_endpoint $ns2 10.0.1.2 flags subflow,fullmesh
30613062
fullmesh=1 speed=slow \
30623063
run_tests $ns1 $ns2 10.0.1.1
30633064
chk_join_nr 3 3 3

0 commit comments

Comments
 (0)