Skip to content

Commit 7840a69

Browse files
superm1alexdeucher
authored andcommitted
drm/amd: Drop unnecessary calls to smu_dpm_set_vpe_enable()
smu_hw_init() and smu_hw_fini() call smu_dpm_set_vpe_enable() for APUs as part of startup and teardown. These calls however are not necessary because vpe_hw_init()/vpe_hw_fini() will call at init/fini: ``` vpe_hw_init() / vpe_hw_fini() amdgpu_device_ip_set_powergating_state() vpe_set_powergating_state() amdgpu_dpm_enable_vpe() amdgpu_dpm_set_powergating_by_smu() smu_dpm_set_power_gate() smu_dpm_set_vpe_enable() ``` Drop the extra calls. Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org> Reviewed-by: Yang Wang <kevinyang.wang@amd.com> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 2740509 commit 7840a69

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1925,7 +1925,6 @@ static int smu_hw_init(struct amdgpu_ip_block *ip_block)
19251925
for (i = 0; i < adev->vcn.num_vcn_inst; i++)
19261926
smu_dpm_set_vcn_enable(smu, true, i);
19271927
smu_dpm_set_jpeg_enable(smu, true);
1928-
smu_dpm_set_vpe_enable(smu, true);
19291928
smu_dpm_set_umsch_mm_enable(smu, true);
19301929
smu_set_mall_enable(smu);
19311930
smu_set_gfx_cgpg(smu, true);
@@ -2133,7 +2132,6 @@ static int smu_hw_fini(struct amdgpu_ip_block *ip_block)
21332132
}
21342133
smu_dpm_set_jpeg_enable(smu, false);
21352134
adev->jpeg.cur_state = AMD_PG_STATE_GATE;
2136-
smu_dpm_set_vpe_enable(smu, false);
21372135
smu_dpm_set_umsch_mm_enable(smu, false);
21382136

21392137
if (!smu->pm_enabled)

0 commit comments

Comments
 (0)