Skip to content

Commit 799a829

Browse files
AndybnACTdavem330
authored andcommitted
net: axienet: start napi before enabling Rx/Tx
softirq may get lost if an Rx interrupt comes before we call napi_enable. Move napi_enable in front of axienet_setoptions(), which turns on the device, to address the issue. Link: https://lists.gnu.org/archive/html/qemu-devel/2024-07/msg06160.html Fixes: cc37610 ("net: axienet: implement NAPI and GRO receive") Signed-off-by: Andy Chiu <andy.chiu@sifive.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 05f76b2 commit 799a829

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/ethernet/xilinx/xilinx_axienet_main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2219,9 +2219,9 @@ static void axienet_dma_err_handler(struct work_struct *work)
22192219
~(XAE_OPTION_TXEN | XAE_OPTION_RXEN));
22202220
axienet_set_mac_address(ndev, NULL);
22212221
axienet_set_multicast_list(ndev);
2222-
axienet_setoptions(ndev, lp->options);
22232222
napi_enable(&lp->napi_rx);
22242223
napi_enable(&lp->napi_tx);
2224+
axienet_setoptions(ndev, lp->options);
22252225
}
22262226

22272227
/**

0 commit comments

Comments
 (0)