Skip to content

Commit 79be2da

Browse files
committed
drm/i915/cdclk: abstract intel_cdclk_actual() and intel_cdclk_actual_voltage_level()
Add intel_cdclk_actual() and intel_cdclk_actual_voltage_level() helpers to avoid looking at struct intel_cdclk_state internals outside of intel_cdclk.c. v2: Better location (Imre) Reviewed-by: Imre Deak <imre.deak@intel.com> Link: https://lore.kernel.org/r/241a9b80a8262b82fded54707ca5622af215dd86.1750847509.git.jani.nikula@intel.com Signed-off-by: Jani Nikula <jani.nikula@intel.com>
1 parent f0bb81b commit 79be2da

3 files changed

Lines changed: 14 additions & 2 deletions

File tree

drivers/gpu/drm/i915/display/intel_cdclk.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3840,6 +3840,16 @@ int intel_cdclk_logical(const struct intel_cdclk_state *cdclk_state)
38403840
return cdclk_state->logical.cdclk;
38413841
}
38423842

3843+
int intel_cdclk_actual(const struct intel_cdclk_state *cdclk_state)
3844+
{
3845+
return cdclk_state->actual.cdclk;
3846+
}
3847+
3848+
int intel_cdclk_actual_voltage_level(const struct intel_cdclk_state *cdclk_state)
3849+
{
3850+
return cdclk_state->actual.voltage_level;
3851+
}
3852+
38433853
int intel_cdclk_min_cdclk(const struct intel_cdclk_state *cdclk_state, enum pipe pipe)
38443854
{
38453855
return cdclk_state->min_cdclk[pipe];

drivers/gpu/drm/i915/display/intel_cdclk.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@ int intel_cdclk_init(struct intel_display *display);
9898
void intel_cdclk_debugfs_register(struct intel_display *display);
9999

100100
int intel_cdclk_logical(const struct intel_cdclk_state *cdclk_state);
101+
int intel_cdclk_actual(const struct intel_cdclk_state *cdclk_state);
102+
int intel_cdclk_actual_voltage_level(const struct intel_cdclk_state *cdclk_state);
101103
int intel_cdclk_min_cdclk(const struct intel_cdclk_state *cdclk_state, enum pipe pipe);
102104
int intel_cdclk_bw_min_cdclk(const struct intel_cdclk_state *cdclk_state);
103105
bool intel_cdclk_pmdemand_needs_update(struct intel_atomic_state *state);

drivers/gpu/drm/i915/display/intel_pmdemand.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -360,9 +360,9 @@ int intel_pmdemand_atomic_check(struct intel_atomic_state *state)
360360
return PTR_ERR(new_cdclk_state);
361361

362362
new_pmdemand_state->params.voltage_index =
363-
new_cdclk_state->actual.voltage_level;
363+
intel_cdclk_actual_voltage_level(new_cdclk_state);
364364
new_pmdemand_state->params.cdclk_freq_mhz =
365-
DIV_ROUND_UP(new_cdclk_state->actual.cdclk, 1000);
365+
DIV_ROUND_UP(intel_cdclk_actual(new_cdclk_state), 1000);
366366

367367
intel_pmdemand_update_max_ddiclk(display, state, new_pmdemand_state);
368368

0 commit comments

Comments
 (0)