Skip to content

Commit 7acb933

Browse files
committed
drm: adp: Remove pointless irq_lock spin lock
Interrupt handlers run with interrupts disabled so it is not necessary to protect them against reentrancy. Signed-off-by: Janne Grunau <j@jannau.net>
1 parent 61093f2 commit 7acb933

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

drivers/gpu/drm/adp/adp_drv.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ struct adp_drv_private {
121121
dma_addr_t mask_iova;
122122
int be_irq;
123123
int fe_irq;
124-
spinlock_t irq_lock;
125124
struct drm_pending_vblank_event *event;
126125
};
127126

@@ -492,8 +491,6 @@ static irqreturn_t adp_fe_irq(int irq, void *arg)
492491
u32 int_status;
493492
u32 int_ctl;
494493

495-
spin_lock(&adp->irq_lock);
496-
497494
int_status = readl(adp->fe + ADP_INT_STATUS);
498495
if (int_status & ADP_INT_STATUS_VBLANK) {
499496
drm_crtc_handle_vblank(&adp->crtc);
@@ -511,7 +508,6 @@ static irqreturn_t adp_fe_irq(int irq, void *arg)
511508

512509
writel(int_status, adp->fe + ADP_INT_STATUS);
513510

514-
spin_unlock(&adp->irq_lock);
515511

516512
return IRQ_HANDLED;
517513
}
@@ -576,8 +572,6 @@ static int adp_probe(struct platform_device *pdev)
576572
if (IS_ERR(adp))
577573
return PTR_ERR(adp);
578574

579-
spin_lock_init(&adp->irq_lock);
580-
581575
dev_set_drvdata(&pdev->dev, &adp->drm);
582576

583577
err = adp_parse_of(pdev, adp);

0 commit comments

Comments
 (0)