Skip to content

Commit 7ae587e

Browse files
Uwe Kleine-Königgroeck
authored andcommitted
hwmon: (smsc47m1) Rename global platform device variable
pdev is a bad name for a global variable. Still more as the driver has functions where pdev is a local variable. Rename it to smsc47m1_pdev. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/68a959b56da7f9452557d08c72249182364b0dd0.1701957841.git.u.kleine-koenig@pengutronix.de Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 5810769 commit 7ae587e

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

drivers/hwmon/smsc47m1.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ static unsigned short force_id;
3333
module_param(force_id, ushort, 0);
3434
MODULE_PARM_DESC(force_id, "Override the detected device ID");
3535

36-
static struct platform_device *pdev;
36+
static struct platform_device *smsc47m1_pdev;
3737

3838
#define DRVNAME "smsc47m1"
3939
enum chips { smsc47m1, smsc47m2 };
@@ -884,10 +884,10 @@ static int __init smsc47m1_device_add(unsigned short address,
884884
if (err)
885885
return err;
886886

887-
pdev = platform_device_register_full(&pdevinfo);
888-
if (IS_ERR(pdev)) {
887+
smsc47m1_pdev = platform_device_register_full(&pdevinfo);
888+
if (IS_ERR(smsc47m1_pdev)) {
889889
pr_err("Device allocation failed\n");
890-
return PTR_ERR(pdev);
890+
return PTR_ERR(smsc47m1_pdev);
891891
}
892892

893893
return 0;
@@ -904,7 +904,7 @@ static int __init sm_smsc47m1_init(void)
904904
return err;
905905
address = err;
906906

907-
/* Sets global pdev as a side effect */
907+
/* Sets global smsc47m1_pdev as a side effect */
908908
err = smsc47m1_device_add(address, &sio_data);
909909
if (err)
910910
return err;
@@ -916,16 +916,16 @@ static int __init sm_smsc47m1_init(void)
916916
return 0;
917917

918918
exit_device:
919-
platform_device_unregister(pdev);
919+
platform_device_unregister(smsc47m1_pdev);
920920
smsc47m1_restore(&sio_data);
921921
return err;
922922
}
923923

924924
static void __exit sm_smsc47m1_exit(void)
925925
{
926926
platform_driver_unregister(&smsc47m1_driver);
927-
smsc47m1_restore(dev_get_platdata(&pdev->dev));
928-
platform_device_unregister(pdev);
927+
smsc47m1_restore(dev_get_platdata(&smsc47m1_pdev->dev));
928+
platform_device_unregister(smsc47m1_pdev);
929929
}
930930

931931
MODULE_AUTHOR("Mark D. Studebaker <mdsxyz123@yahoo.com>");

0 commit comments

Comments
 (0)