Skip to content

Commit 7afd533

Browse files
sicelolag-linaro
authored andcommitted
leds: lp55xx_common: Enable use without FW_LOADER_USER_HELPER
Many distributions disable FW_LOADER_USER_HELPER, and this configuration makes lp55xx LEDs completely unusable. Enable their use by only implying the user helper, since the basic LEDs and the hardware patterns can be used with only the sysfs interface. Tested on Nokia N900 with LP5523. Additionally do not refer to the sysfs interface as legacy anymore, since it might be the only one available to users. Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com> Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 2a7ee99 commit 7afd533

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

Documentation/leds/leds-lp5521.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ More details of the instructions can be found from the public data sheet.
2222
LP5521 has the internal program memory for running various LED patterns.
2323
There are two ways to run LED patterns.
2424

25-
1) Legacy interface - enginex_mode and enginex_load
25+
1) sysfs interface - enginex_mode and enginex_load
2626
Control interface for the engines:
2727

2828
x is 1 .. 3

Documentation/leds/leds-lp5523.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ If both fields are NULL, 'lp5523' is used by default.
3535
LP5523 has the internal program memory for running various LED patterns.
3636
There are two ways to run LED patterns.
3737

38-
1) Legacy interface - enginex_mode, enginex_load and enginex_leds
38+
1) sysfs interface - enginex_mode, enginex_load and enginex_leds
3939

4040
Control interface for the engines:
4141

drivers/leds/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,8 +443,8 @@ config LEDS_LP55XX_COMMON
443443
depends on LEDS_CLASS_MULTICOLOR
444444
depends on OF
445445
depends on I2C
446-
select FW_LOADER
447-
select FW_LOADER_USER_HELPER
446+
imply FW_LOADER
447+
imply FW_LOADER_USER_HELPER
448448
help
449449
This option supports common operations for LP5521/5523/55231/5562/5569/
450450
8501 devices.

0 commit comments

Comments
 (0)