Skip to content

Commit 7b3685c

Browse files
committed
drm/i915/dsi: Fix off by one in BXT_MIPI_TRANS_VTOTAL
BXT_MIPI_TRANS_VTOTAL must be programmed with vtotal-1 instead of vtotal. Make it so. Cc: stable@vger.kernel.org Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250314150136.22564-1-ville.syrjala@linux.intel.com Reviewed-by: Jani Nikula <jani.nikula@intel.com>
1 parent ed3648b commit 7b3685c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/gpu/drm/i915/display/vlv_dsi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,7 +1055,7 @@ static void bxt_dsi_get_pipe_config(struct intel_encoder *encoder,
10551055
BXT_MIPI_TRANS_VACTIVE(port));
10561056
adjusted_mode->crtc_vtotal =
10571057
intel_de_read(display,
1058-
BXT_MIPI_TRANS_VTOTAL(port));
1058+
BXT_MIPI_TRANS_VTOTAL(port)) + 1;
10591059

10601060
hactive = adjusted_mode->crtc_hdisplay;
10611061
hfp = intel_de_read(display, MIPI_HFP_COUNT(display, port));
@@ -1259,7 +1259,7 @@ static void set_dsi_timings(struct intel_encoder *encoder,
12591259
intel_de_write(display, BXT_MIPI_TRANS_VACTIVE(port),
12601260
adjusted_mode->crtc_vdisplay);
12611261
intel_de_write(display, BXT_MIPI_TRANS_VTOTAL(port),
1262-
adjusted_mode->crtc_vtotal);
1262+
adjusted_mode->crtc_vtotal - 1);
12631263
}
12641264

12651265
intel_de_write(display, MIPI_HACTIVE_AREA_COUNT(display, port),

0 commit comments

Comments
 (0)