Skip to content

Commit 7e71fa6

Browse files
Robert Richterdavejiang
authored andcommitted
cxl/region: Remove local variable @inc in cxl_port_setup_targets()
Simplify the code by removing local variable @inc. The variable is not used elsewhere, remove it and directly increment the target number. Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com> Signed-off-by: Robert Richter <rrichter@amd.com> Link: https://patch.msgid.link/20251114075844.1315805-4-rrichter@amd.com Signed-off-by: Dave Jiang <dave.jiang@intel.com>
1 parent c42a4d2 commit 7e71fa6

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/cxl/core/region.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1328,7 +1328,7 @@ static int cxl_port_setup_targets(struct cxl_port *port,
13281328
struct cxl_endpoint_decoder *cxled)
13291329
{
13301330
struct cxl_root_decoder *cxlrd = to_cxl_root_decoder(cxlr->dev.parent);
1331-
int parent_iw, parent_ig, ig, iw, rc, inc = 0, pos = cxled->pos;
1331+
int parent_iw, parent_ig, ig, iw, rc, pos = cxled->pos;
13321332
struct cxl_port *parent_port = to_cxl_port(port->dev.parent);
13331333
struct cxl_region_ref *cxl_rr = cxl_rr_load(port, cxlr);
13341334
struct cxl_memdev *cxlmd = cxled_to_memdev(cxled);
@@ -1520,9 +1520,8 @@ static int cxl_port_setup_targets(struct cxl_port *port,
15201520
cxlsd->target[cxl_rr->nr_targets_set] = ep->dport;
15211521
cxlsd->cxld.target_map[cxl_rr->nr_targets_set] = ep->dport->port_id;
15221522
}
1523-
inc = 1;
1523+
cxl_rr->nr_targets_set++;
15241524
out_target_set:
1525-
cxl_rr->nr_targets_set += inc;
15261525
dev_dbg(&cxlr->dev, "%s:%s target[%d] = %s for %s:%s @ %d\n",
15271526
dev_name(port->uport_dev), dev_name(&port->dev),
15281527
cxl_rr->nr_targets_set - 1, dev_name(ep->dport->dport_dev),

0 commit comments

Comments
 (0)