Skip to content

Commit 7f77c56

Browse files
BoughChenprati0100
authored andcommitted
mtd: spi-nor: micron-st: add TODO for fixing mt35xu02gcba
The MT35XU02GCBA flash device does not support chip erase, according to its datasheet. It supports die erase, which means the current driver implementation will likely need to be converted to use die erase. Furthermore, similar to the MT35XU01GBBA, the SPI_NOR_IO_MODE_EN_VOLATILE flag probably needs to be enabled. Currently no active contributor has access to this hardware so there is no way of testing the fixes. Add a TODO item on the flash entry so someone with the flash can test that the support is indeed broken and send the fixes. Link: https://datasheet.octopart.com/MT35XU02GCBA1G12-0AAT-Micron-datasheet-138896808.pdf Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> Signed-off-by: Haibo Chen <haibo.chen@nxp.com> [pratyush@kernel.org: refactor the comment and commit message to make the purpose of the comment clearer] Signed-off-by: Pratyush Yadav <pratyush@kernel.org>
1 parent a5dff51 commit 7f77c56

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

drivers/mtd/spi-nor/micron-st.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,16 @@ static const struct flash_info micron_nor_parts[] = {
204204
.fixup_flags = SPI_NOR_IO_MODE_EN_VOLATILE,
205205
.fixups = &mt35xu01gbba_fixups,
206206
}, {
207+
/*
208+
* The MT35XU02GCBA flash device does not support chip erase,
209+
* according to its datasheet. It supports die erase, which
210+
* means the current driver implementation will likely need to
211+
* be converted to use die erase. Furthermore, similar to the
212+
* MT35XU01GBBA, the SPI_NOR_IO_MODE_EN_VOLATILE flag probably
213+
* needs to be enabled.
214+
*
215+
* TODO: Fix these and test on real hardware.
216+
*/
207217
.id = SNOR_ID(0x2c, 0x5b, 0x1c),
208218
.name = "mt35xu02g",
209219
.sector_size = SZ_128K,

0 commit comments

Comments
 (0)