Skip to content

Commit 7fa678c

Browse files
committed
drm/display: Select DRM_KMS_HELPER for DP helpers
The DisplayPort helpers rely on some (__drm_atomic_helper_private_obj_duplicate_state, drm_kms_helper_hotplug_event) helpers found in files compiled by DRM_KMS_HELPER. Prior to commit d674858 ("drm/display: Make all helpers visible and switch to depends on"), DRM_DISPLAY_DP_HELPER was only selectable so it wasn't really a big deal. However, since that commit, it's now something that can be enabled as is, and since there's no expressed dependency with DRM_KMS_HELPER, it can break too. Since DRM_KMS_HELPER is a selectable option for now, let's select it for DRM_DISPLAY_DP_HELPER. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202404021556.0JVcNC13-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202404021700.LbyYZGFd-lkp@intel.com/ Fixes: d674858 ("drm/display: Make all helpers visible and switch to depends on") Reviewed-by: Mark Brown <broonie@kernel.org> Signed-off-by: Maxime Ripard <mripard@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20240403-fix-dw-hdmi-kconfig-v1-1-afbc4a835c38@kernel.org
1 parent d1ef8fc commit 7fa678c

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/gpu/drm/display/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ config DRM_DISPLAY_DP_AUX_CHARDEV
3939
config DRM_DISPLAY_DP_HELPER
4040
bool "DRM DisplayPort Helpers"
4141
depends on DRM_DISPLAY_HELPER
42+
select DRM_KMS_HELPER
4243
default y
4344
help
4445
DRM display helpers for DisplayPort.

0 commit comments

Comments
 (0)