Skip to content

Commit 804f98e

Browse files
LuBaoluwilldeacon
authored andcommitted
iommu/vt-d: Downgrade warning for pre-enabled IR
Emitting a warning is overkill in intel_setup_irq_remapping() since the interrupt remapping is pre-enabled. For example, there's no guarantee that kexec will explicitly disable interrupt remapping before booting a new kernel. As a result, users are seeing warning messages like below when they kexec boot a kernel, though there is nothing wrong: DMAR-IR: IRQ remapping was enabled on dmar18 but we are not in kdump mode DMAR-IR: IRQ remapping was enabled on dmar17 but we are not in kdump mode DMAR-IR: IRQ remapping was enabled on dmar16 but we are not in kdump mode ... ... Downgrade the severity of this message to avoid user confusion. CC: Paul Menzel <pmenzel@molgen.mpg.de> Link: https://lore.kernel.org/linux-iommu/5517f76a-94ad-452c-bae6-34ecc0ec4831@molgen.mpg.de/ Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> Reviewed-by: Kevin Tian <kevin.tian@intel.com> Link: https://lore.kernel.org/r/20240625043912.258036-1-baolu.lu@linux.intel.com Link: https://lore.kernel.org/r/20240702130839.108139-5-baolu.lu@linux.intel.com Signed-off-by: Will Deacon <will@kernel.org>
1 parent e995fcd commit 804f98e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/iommu/intel/irq_remapping.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -597,8 +597,8 @@ static int intel_setup_irq_remapping(struct intel_iommu *iommu)
597597

598598
if (ir_pre_enabled(iommu)) {
599599
if (!is_kdump_kernel()) {
600-
pr_warn("IRQ remapping was enabled on %s but we are not in kdump mode\n",
601-
iommu->name);
600+
pr_info_once("IRQ remapping was enabled on %s but we are not in kdump mode\n",
601+
iommu->name);
602602
clear_ir_pre_enabled(iommu);
603603
iommu_disable_irq_remapping(iommu);
604604
} else if (iommu_load_old_irte(iommu))

0 commit comments

Comments
 (0)