ALSA: hda: tas2781-spi: Fix error code in tas2781_read_acpi()

Dan Carpenter · tiwai · commit 807563cdc85d · 2025-01-22T09:28:42.000+01:00
Propagate the error code from devm_gpiod_get_index_optional(). The current code returns success. Fixes: bb5f86e ("ALSA: hda/tas2781: Add tas2781 hda SPI driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://patch.msgid.link/6103e81a-13bf-4eab-89af-f6830c14e14c@stanley.mountain Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/pci/hda/tas2781_hda_spi.c b/sound/pci/hda/tas2781_hda_spi.c
@@ -447,6 +447,7 @@ static int tas2781_read_acpi(struct tas2781_hda *tas_hda,
 		p->reset = devm_gpiod_get_index_optional(physdev, "reset",
 			p->index, GPIOD_OUT_LOW);
 		if (IS_ERR(p->reset)) {
+			ret = PTR_ERR(p->reset);
 			dev_err_probe(p->dev, ret, "Failed on reset GPIO\n");
 			goto err;
 		}

Original file line number	Diff line number	Diff line change
`@@ -447,6 +447,7 @@ static int tas2781_read_acpi(struct tas2781_hda *tas_hda,`
`447`	`447`	`p->reset = devm_gpiod_get_index_optional(physdev, "reset",`
`448`	`448`	`p->index, GPIOD_OUT_LOW);`
`449`	`449`	`if (IS_ERR(p->reset)) {`
	`450`	`+ ret = PTR_ERR(p->reset);`
`450`	`451`	`dev_err_probe(p->dev, ret, "Failed on reset GPIO\n");`
`451`	`452`	`goto err;`
`452`	`453`	`}`