crypto: zstd - Fix compression bug caused by truncation

herbertx · herbertx · commit 81c1a15eb4a2 · 2025-10-02T15:02:44.000+08:00
Use size_t for the return value of zstd_compress_cctx as otherwise negative errors will be truncated to a positive value. Reported-by: Han Xu <han.xu@nxp.com> Fixes: f5ad93f ("crypto: zstd - convert to acomp") Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Reviewed-by: David Sterba <dsterba@suse.com> Tested-by: Han Xu <han.xu@nxp.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/crypto/zstd.c b/crypto/zstd.c
@@ -83,7 +83,7 @@ static void zstd_exit(struct crypto_acomp *acomp_tfm)
 static int zstd_compress_one(struct acomp_req *req, struct zstd_ctx *ctx,
 			     const void *src, void *dst, unsigned int *dlen)
 {
-	unsigned int out_len;
+	size_t out_len;
 
 	ctx->cctx = zstd_init_cctx(ctx->wksp, ctx->wksp_size);
 	if (!ctx->cctx)

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ static void zstd_exit(struct crypto_acomp *acomp_tfm)`
`83`	`83`	`static int zstd_compress_one(struct acomp_req req, struct zstd_ctx ctx,`
`84`	`84`	`const void src, void dst, unsigned int *dlen)`
`85`	`85`	`{`
`86`		`- unsigned int out_len;`
	`86`	`+ size_t out_len;`
`87`	`87`
`88`	`88`	`ctx->cctx = zstd_init_cctx(ctx->wksp, ctx->wksp_size);`
`89`	`89`	`if (!ctx->cctx)`