Skip to content

Commit 81f6416

Browse files
Baochen Qiangjeff-t-johnson
authored andcommitted
wifi: ath11k: adjust unlock sequence in ath11k_update_stats_event()
Currently RCU lock and ar->data_lock are acquired in a sequence of rcu_read_lock() spin_lock_bh(&ar->data_lock) but released in a sequence of rcu_read_unlock() spin_unlock_bh(&ar->data_lock) Although there are no apparent issues with this, reorder them to achieve symmetry. Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.37 Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> Acked-by: Kalle Valo <kvalo@kernel.org> Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com> Link: https://patch.msgid.link/20250220082448.31039-6-quic_bqiang@quicinc.com Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
1 parent 72610ed commit 81f6416

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • drivers/net/wireless/ath/ath11k

drivers/net/wireless/ath/ath11k/wmi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8238,8 +8238,8 @@ static void ath11k_update_stats_event(struct ath11k_base *ab, struct sk_buff *sk
82388238

82398239
complete:
82408240
complete(&ar->fw_stats_complete);
8241-
rcu_read_unlock();
82428241
spin_unlock_bh(&ar->data_lock);
8242+
rcu_read_unlock();
82438243

82448244
/* Since the stats's pdev, vdev and beacon list are spliced and reinitialised
82458245
* at this point, no need to free the individual list.

0 commit comments

Comments
 (0)