Skip to content

Commit 82caa1c

Browse files
uma-inteljnikula
authored andcommitted
drm/i915/color: Program Pre-CSC registers
Add callback to program Pre-CSC LUT for TGL and beyond v2: Add DSB support v3: Add support for single segment 1D LUT color op v4: - s/drm_color_lut_32/drm_color_lut32/ (Simon) - Change commit message (Suraj) - Improve comments (Suraj) - Remove multisegmented programming, to be added later - Remove dead code for SDR planes, add when needed BSpec: 50411, 50412, 50413, 50414 Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com> Signed-off-by: Uma Shankar <uma.shankar@intel.com> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com> Link: https://patch.msgid.link/20251203085211.3663374-12-uma.shankar@intel.com Signed-off-by: Jani Nikula <jani.nikula@intel.com>
1 parent 3b7476e commit 82caa1c

1 file changed

Lines changed: 61 additions & 0 deletions

File tree

drivers/gpu/drm/i915/display/intel_color.c

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3943,6 +3943,66 @@ xelpd_load_plane_csc_matrix(struct intel_dsb *dsb,
39433943
ctm_to_twos_complement(input[11], 0, 12));
39443944
}
39453945

3946+
static void
3947+
xelpd_program_plane_pre_csc_lut(struct intel_dsb *dsb,
3948+
const struct intel_plane_state *plane_state)
3949+
{
3950+
struct intel_display *display = to_intel_display(plane_state);
3951+
const struct drm_plane_state *state = &plane_state->uapi;
3952+
enum pipe pipe = to_intel_plane(state->plane)->pipe;
3953+
enum plane_id plane = to_intel_plane(state->plane)->id;
3954+
const struct drm_color_lut32 *pre_csc_lut = plane_state->hw.degamma_lut->data;
3955+
u32 i, lut_size;
3956+
3957+
if (icl_is_hdr_plane(display, plane)) {
3958+
lut_size = 128;
3959+
3960+
intel_de_write_dsb(display, dsb,
3961+
PLANE_PRE_CSC_GAMC_INDEX_ENH(pipe, plane, 0),
3962+
PLANE_PAL_PREC_AUTO_INCREMENT);
3963+
3964+
if (pre_csc_lut) {
3965+
for (i = 0; i < lut_size; i++) {
3966+
u32 lut_val = drm_color_lut32_extract(pre_csc_lut[i].green, 24);
3967+
3968+
intel_de_write_dsb(display, dsb,
3969+
PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
3970+
lut_val);
3971+
}
3972+
3973+
/* Program the max register to clamp values > 1.0. */
3974+
/* TODO: Restrict to 0x7ffffff */
3975+
do {
3976+
intel_de_write_dsb(display, dsb,
3977+
PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
3978+
(1 << 24));
3979+
} while (i++ > 130);
3980+
} else {
3981+
for (i = 0; i < lut_size; i++) {
3982+
u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1);
3983+
3984+
intel_de_write_dsb(display, dsb,
3985+
PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0), v);
3986+
}
3987+
3988+
do {
3989+
intel_de_write_dsb(display, dsb,
3990+
PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, 0),
3991+
1 << 24);
3992+
} while (i++ < 130);
3993+
}
3994+
3995+
intel_de_write_dsb(display, dsb, PLANE_PRE_CSC_GAMC_INDEX_ENH(pipe, plane, 0), 0);
3996+
}
3997+
}
3998+
3999+
static void
4000+
xelpd_plane_load_luts(struct intel_dsb *dsb, const struct intel_plane_state *plane_state)
4001+
{
4002+
if (plane_state->hw.degamma_lut)
4003+
xelpd_program_plane_pre_csc_lut(dsb, plane_state);
4004+
}
4005+
39464006
static const struct intel_color_funcs chv_color_funcs = {
39474007
.color_check = chv_color_check,
39484008
.color_commit_arm = i9xx_color_commit_arm,
@@ -3991,6 +4051,7 @@ static const struct intel_color_funcs tgl_color_funcs = {
39914051
.read_csc = icl_read_csc,
39924052
.get_config = skl_get_config,
39934053
.load_plane_csc_matrix = xelpd_load_plane_csc_matrix,
4054+
.load_plane_luts = xelpd_plane_load_luts,
39944055
};
39954056

39964057
static const struct intel_color_funcs icl_color_funcs = {

0 commit comments

Comments
 (0)