crypto: aspeed - Fix dma_unmap_sg() direction

Thomas-fourier · herbertx · commit 838d2d51513e · 2025-09-20T20:21:03.000+08:00
It seems like everywhere in this file, when the request is not bidirectionala, req->src is mapped with DMA_TO_DEVICE and req->dst is mapped with DMA_FROM_DEVICE. Fixes: 62f58b1 ("crypto: aspeed - add HACE crypto driver") Cc: <stable@vger.kernel.org> Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/drivers/crypto/aspeed/aspeed-hace-crypto.c b/drivers/crypto/aspeed/aspeed-hace-crypto.c
@@ -346,7 +346,7 @@ static int aspeed_sk_start_sg(struct aspeed_hace_dev *hace_dev)
 
 	} else {
 		dma_unmap_sg(hace_dev->dev, req->dst, rctx->dst_nents,
-			     DMA_TO_DEVICE);
+			     DMA_FROM_DEVICE);
 		dma_unmap_sg(hace_dev->dev, req->src, rctx->src_nents,
 			     DMA_TO_DEVICE);
 	}

Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,7 @@ static int aspeed_sk_start_sg(struct aspeed_hace_dev *hace_dev)`
`346`	`346`
`347`	`347`	`} else {`
`348`	`348`	`dma_unmap_sg(hace_dev->dev, req->dst, rctx->dst_nents,`
`349`		`- DMA_TO_DEVICE);`
	`349`	`+ DMA_FROM_DEVICE);`
`350`	`350`	`dma_unmap_sg(hace_dev->dev, req->src, rctx->src_nents,`
`351`	`351`	`DMA_TO_DEVICE);`
`352`	`352`	`}`