Skip to content

Commit 839052d

Browse files
Wolfram SangAndi Shyti
authored andcommitted
i2c: mt7621: reword according to newest specification
Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2 specifications and replace "master/slave" with more appropriate terms. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Stefan Roese <sr@denx.de> Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
1 parent 234b336 commit 839052d

1 file changed

Lines changed: 13 additions & 13 deletions

File tree

drivers/i2c/busses/i2c-mt7621.c

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -117,27 +117,27 @@ static int mtk_i2c_check_ack(struct mtk_i2c *i2c, u32 expected)
117117
return ((ack & ack_expected) == ack_expected) ? 0 : -ENXIO;
118118
}
119119

120-
static int mtk_i2c_master_start(struct mtk_i2c *i2c)
120+
static int mtk_i2c_start(struct mtk_i2c *i2c)
121121
{
122122
iowrite32(SM0CTL1_START | SM0CTL1_TRI, i2c->base + REG_SM0CTL1_REG);
123123
return mtk_i2c_wait_idle(i2c);
124124
}
125125

126-
static int mtk_i2c_master_stop(struct mtk_i2c *i2c)
126+
static int mtk_i2c_stop(struct mtk_i2c *i2c)
127127
{
128128
iowrite32(SM0CTL1_STOP | SM0CTL1_TRI, i2c->base + REG_SM0CTL1_REG);
129129
return mtk_i2c_wait_idle(i2c);
130130
}
131131

132-
static int mtk_i2c_master_cmd(struct mtk_i2c *i2c, u32 cmd, int page_len)
132+
static int mtk_i2c_cmd(struct mtk_i2c *i2c, u32 cmd, int page_len)
133133
{
134134
iowrite32(cmd | SM0CTL1_TRI | SM0CTL1_PGLEN(page_len),
135135
i2c->base + REG_SM0CTL1_REG);
136136
return mtk_i2c_wait_idle(i2c);
137137
}
138138

139-
static int mtk_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
140-
int num)
139+
static int mtk_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
140+
int num)
141141
{
142142
struct mtk_i2c *i2c;
143143
struct i2c_msg *pmsg;
@@ -157,7 +157,7 @@ static int mtk_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
157157
goto err_timeout;
158158

159159
/* start sequence */
160-
ret = mtk_i2c_master_start(i2c);
160+
ret = mtk_i2c_start(i2c);
161161
if (ret)
162162
goto err_timeout;
163163

@@ -169,14 +169,14 @@ static int mtk_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
169169
if (pmsg->flags & I2C_M_RD)
170170
addr |= 1;
171171
iowrite32(addr, i2c->base + REG_SM0D0_REG);
172-
ret = mtk_i2c_master_cmd(i2c, SM0CTL1_WRITE, 2);
172+
ret = mtk_i2c_cmd(i2c, SM0CTL1_WRITE, 2);
173173
if (ret)
174174
goto err_timeout;
175175
} else {
176176
/* 7 bits address */
177177
addr = i2c_8bit_addr_from_msg(pmsg);
178178
iowrite32(addr, i2c->base + REG_SM0D0_REG);
179-
ret = mtk_i2c_master_cmd(i2c, SM0CTL1_WRITE, 1);
179+
ret = mtk_i2c_cmd(i2c, SM0CTL1_WRITE, 1);
180180
if (ret)
181181
goto err_timeout;
182182
}
@@ -202,7 +202,7 @@ static int mtk_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
202202
cmd = SM0CTL1_WRITE;
203203
}
204204

205-
ret = mtk_i2c_master_cmd(i2c, cmd, page_len);
205+
ret = mtk_i2c_cmd(i2c, cmd, page_len);
206206
if (ret)
207207
goto err_timeout;
208208

@@ -222,15 +222,15 @@ static int mtk_i2c_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
222222
}
223223
}
224224

225-
ret = mtk_i2c_master_stop(i2c);
225+
ret = mtk_i2c_stop(i2c);
226226
if (ret)
227227
goto err_timeout;
228228

229229
/* the return value is number of executed messages */
230230
return i;
231231

232232
err_ack:
233-
ret = mtk_i2c_master_stop(i2c);
233+
ret = mtk_i2c_stop(i2c);
234234
if (ret)
235235
goto err_timeout;
236236
return -ENXIO;
@@ -247,8 +247,8 @@ static u32 mtk_i2c_func(struct i2c_adapter *a)
247247
}
248248

249249
static const struct i2c_algorithm mtk_i2c_algo = {
250-
.master_xfer = mtk_i2c_master_xfer,
251-
.functionality = mtk_i2c_func,
250+
.xfer = mtk_i2c_xfer,
251+
.functionality = mtk_i2c_func,
252252
};
253253

254254
static const struct of_device_id i2c_mtk_dt_ids[] = {

0 commit comments

Comments
 (0)