Skip to content

Commit 84a9052

Browse files
eghidolikuba-moo
authored andcommitted
net: phy: dp83867: Disable EEE support as not implemented
While the DP83867 PHYs report EEE capability through their feature registers, the actual hardware does not support EEE (see Links). When the connected MAC enables EEE, it causes link instability and communication failures. The issue is reproducible with a iMX8MP and relevant stmmac ethernet port. Since the introduction of phylink-managed EEE support in the stmmac driver, EEE is now enabled by default, leading to issues on systems using the DP83867 PHY. Call phy_disable_eee during phy initialization to prevent EEE from being enabled on DP83867 PHYs. Link: https://e2e.ti.com/support/interface-group/interface/f/interface-forum/1445244/dp83867ir-dp83867-disable-eee-lpi Link: https://e2e.ti.com/support/interface-group/interface/f/interface-forum/658638/dp83867ir-eee-energy-efficient-ethernet Fixes: 2a10154 ("net: phy: dp83867: Add TI dp83867 phy") Cc: stable@vger.kernel.org Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://patch.msgid.link/20251023144857.529566-1-ghidoliemanuele@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 1ab6658 commit 84a9052

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

drivers/net/phy/dp83867.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -738,6 +738,12 @@ static int dp83867_config_init(struct phy_device *phydev)
738738
return ret;
739739
}
740740

741+
/* Although the DP83867 reports EEE capability through the
742+
* MDIO_PCS_EEE_ABLE and MDIO_AN_EEE_ADV registers, the feature
743+
* is not actually implemented in hardware.
744+
*/
745+
phy_disable_eee(phydev);
746+
741747
if (phy_interface_is_rgmii(phydev) ||
742748
phydev->interface == PHY_INTERFACE_MODE_SGMII) {
743749
val = phy_read(phydev, MII_DP83867_PHYCTRL);

0 commit comments

Comments
 (0)