Skip to content

Commit 8577441

Browse files
DispatchCodeaxboe
authored andcommitted
io_uring: replace use of system_wq with system_percpu_wq
Currently if a user enqueue a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistentcy cannot be addressed without refactoring the API. system_wq is a per-CPU worqueue, yet nothing in its name tells about that CPU affinity constraint, which is very often not required by users. Make it clear by adding a system_percpu_wq. queue_work() / queue_delayed_work() mod_delayed_work() will now use the new per-cpu wq: whether the user still stick on the old name a warn will be printed along a wq redirect to the new one. This patch add the new system_percpu_wq except for mm, fs and net subsystem, whom are handled in separated patches. The old wq will be kept for a few release cylces. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 2f076a4 commit 8577441

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

io_uring/io_uring.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3106,7 +3106,7 @@ static __cold void io_ring_ctx_wait_and_kill(struct io_ring_ctx *ctx)
31063106
* Use system_unbound_wq to avoid spawning tons of event kworkers
31073107
* if we're exiting a ton of rings at the same time. It just adds
31083108
* noise and overhead, there's no discernable change in runtime
3109-
* over using system_wq.
3109+
* over using system_percpu_wq.
31103110
*/
31113111
queue_work(iou_wq, &ctx->exit_work);
31123112
}

0 commit comments

Comments
 (0)