Skip to content

Commit 8625f57

Browse files
pmachatakuba-moo
authored andcommitted
net: bridge: Bounce invalid boolopts
The bridge driver currently tolerates options that it does not recognize. Instead, it should bounce them. Fixes: a428afe ("net: bridge: add support for user-controlled bool options") Signed-off-by: Petr Machata <petrm@nvidia.com> Reviewed-by: Ido Schimmel <idosch@nvidia.com> Acked-by: Nikolay Aleksandrov <razor@blackwall.org> Link: https://patch.msgid.link/e6fdca3b5a8d54183fbda075daffef38bdd7ddce.1757070067.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 674b34c commit 8625f57

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

net/bridge/br.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,13 @@ int br_boolopt_multi_toggle(struct net_bridge *br,
324324
int err = 0;
325325
int opt_id;
326326

327+
opt_id = find_next_bit(&bitmap, BITS_PER_LONG, BR_BOOLOPT_MAX);
328+
if (opt_id != BITS_PER_LONG) {
329+
NL_SET_ERR_MSG_FMT_MOD(extack, "Unknown boolean option %d",
330+
opt_id);
331+
return -EINVAL;
332+
}
333+
327334
for_each_set_bit(opt_id, &bitmap, BR_BOOLOPT_MAX) {
328335
bool on = !!(bm->optval & BIT(opt_id));
329336

0 commit comments

Comments
 (0)