ASoC: codec: tlv320aic32x4: Fix reset GPIO check

tq-steina · broonie · commit 8778837f0a5b · 2025-07-16T11:15:20.000+01:00
rstn_gpio being a GPIO descriptor the check is wrong (inverted) for releasing the reset of the codec. Fixes: 790d5f8 ("ASoC: codec: tlv320aic32x4: Convert to GPIO descriptors") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by: Peng Fan <peng.fan@nxp.com> Link: https://patch.msgid.link/20250716065708.4041153-1-alexander.stein@ew.tq-group.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c
@@ -1388,7 +1388,7 @@ int aic32x4_probe(struct device *dev, struct regmap *regmap,
 		return ret;
 	}
 
-	if (!aic32x4->rstn_gpio) {
+	if (aic32x4->rstn_gpio) {
 		ndelay(10);
 		/* deassert reset */
 		gpiod_set_value_cansleep(aic32x4->rstn_gpio, 0);

Original file line number	Diff line number	Diff line change
`@@ -1388,7 +1388,7 @@ int aic32x4_probe(struct device dev, struct regmap regmap,`
`1388`	`1388`	`return ret;`
`1389`	`1389`	`}`
`1390`	`1390`
`1391`		`- if (!aic32x4->rstn_gpio) {`
	`1391`	`+ if (aic32x4->rstn_gpio) {`
`1392`	`1392`	`ndelay(10);`
`1393`	`1393`	`/* deassert reset */`
`1394`	`1394`	`gpiod_set_value_cansleep(aic32x4->rstn_gpio, 0);`