Skip to content

Commit 88ef4de

Browse files
amd-yangpalexdeucher
authored andcommitted
Revert "drm/amdkfd: Improve signal event slow path"
To fix regression report on gfx8, which requires the exhaustive search path for signaled event. The high CPU usage of KFD interrupt wq issue is gone after HIP/ROCr add option to reduce HW event interrupts, safe to revert this optimization patch now. This reverts commit de84484. Signed-off-by: Philip Yang <Philip.Yang@amd.com> Acked-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent f19bbec commit 88ef4de

1 file changed

Lines changed: 0 additions & 11 deletions

File tree

drivers/gpu/drm/amd/amdkfd/kfd_events.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -748,16 +748,6 @@ void kfd_signal_event_interrupt(u32 pasid, uint32_t partial_id,
748748
uint64_t *slots = page_slots(p->signal_page);
749749
uint32_t id;
750750

751-
/*
752-
* If id is valid but slot is not signaled, GPU may signal the same event twice
753-
* before driver have chance to process the first interrupt, then signal slot is
754-
* auto-reset after set_event wakeup the user space, just drop the second event as
755-
* the application only need wakeup once.
756-
*/
757-
if ((valid_id_bits > 31 || (1U << valid_id_bits) >= KFD_SIGNAL_EVENT_LIMIT) &&
758-
partial_id < KFD_SIGNAL_EVENT_LIMIT && slots[partial_id] == UNSIGNALED_EVENT_SLOT)
759-
goto out_unlock;
760-
761751
if (valid_id_bits)
762752
pr_debug_ratelimited("Partial ID invalid: %u (%u valid bits)\n",
763753
partial_id, valid_id_bits);
@@ -786,7 +776,6 @@ void kfd_signal_event_interrupt(u32 pasid, uint32_t partial_id,
786776
}
787777
}
788778

789-
out_unlock:
790779
rcu_read_unlock();
791780
kfd_unref_process(p);
792781
}

0 commit comments

Comments
 (0)