Skip to content

Commit 8a81236

Browse files
Gunnar Kudrjavetsjarkkojs
authored andcommitted
tpm_tis: Fix incorrect arguments in tpm_tis_probe_irq_single
The tpm_tis_write8() call specifies arguments in wrong order. Should be (data, addr, value) not (data, value, addr). The initial correct order was changed during the major refactoring when the code was split. Fixes: 41a5e1c ("tpm/tpm_tis: Split tpm_tis driver into a core and TCG TIS compliant phy") Signed-off-by: Gunnar Kudrjavets <gunnarku@amazon.com> Reviewed-by: Justinien Bouron <jbouron@amazon.com> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
1 parent 64a7cfb commit 8a81236

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/char/tpm/tpm_tis_core.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -978,8 +978,8 @@ static int tpm_tis_probe_irq_single(struct tpm_chip *chip, u32 intmask,
978978
* will call disable_irq which undoes all of the above.
979979
*/
980980
if (!(chip->flags & TPM_CHIP_FLAG_IRQ)) {
981-
tpm_tis_write8(priv, original_int_vec,
982-
TPM_INT_VECTOR(priv->locality));
981+
tpm_tis_write8(priv, TPM_INT_VECTOR(priv->locality),
982+
original_int_vec);
983983
rc = -1;
984984
}
985985

0 commit comments

Comments
 (0)