Skip to content

Commit 8ac2a19

Browse files
jgross1groeck
authored andcommitted
hwmon/lm78: Drop REALLY_SLOW_IO setting
In lm78_isa_found() there is REALLY_SLOW_IO defined around some port accesses, probably in order to wait between multiple accesses. Unfortunately this isn't making any difference compared to not having this define since more than a decade, as REALLY_SLOW_IO needs to be defined while "#include <asm/io.h>" is called to have an effect. As there seem not to be any outstanding issues in spite of this having no effect, just drop the "#define" and add a remark to the related comment. Signed-off-by: Juergen Gross <jgross@suse.com> Link: https://lore.kernel.org/r/20251126162018.5676-3-jgross@suse.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 2f88425 commit 8ac2a19

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

drivers/hwmon/lm78.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -843,17 +843,18 @@ static int __init lm78_isa_found(unsigned short address)
843843
}
844844
}
845845

846-
#define REALLY_SLOW_IO
847846
/*
848847
* We need the timeouts for at least some LM78-like
849848
* chips. But only if we read 'undefined' registers.
849+
* There used to be a "#define REALLY_SLOW_IO" to enforce that, but
850+
* this has been without any effect since more than a decade, so it
851+
* has been dropped.
850852
*/
851853
val = inb_p(address + 1);
852854
if (inb_p(address + 2) != val
853855
|| inb_p(address + 3) != val
854856
|| inb_p(address + 7) != val)
855857
goto release;
856-
#undef REALLY_SLOW_IO
857858

858859
/*
859860
* We should be able to change the 7 LSB of the address port. The

0 commit comments

Comments
 (0)