Skip to content

Commit 8b27fe2

Browse files
Ivan Abramovsre
authored andcommitted
power: supply: rt9467: Return error on failure in rt9467_set_value_from_ranges()
The return value of rt9467_set_value_from_ranges() when setting AICL VTH is not checked, even though it may fail. Log error and return from rt9467_run_aicl() on fail. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 6f7f70e ("power: supply: rt9467: Add Richtek RT9467 charger driver") Signed-off-by: Ivan Abramov <i.abramov@mt-integration.ru> Link: https://patch.msgid.link/20251009144725.562278-1-i.abramov@mt-integration.ru Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
1 parent 2c68ac4 commit 8b27fe2

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

drivers/power/supply/rt9467-charger.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -588,6 +588,10 @@ static int rt9467_run_aicl(struct rt9467_chg_data *data)
588588
aicl_vth = mivr_vth + RT9467_AICLVTH_GAP_uV;
589589
ret = rt9467_set_value_from_ranges(data, F_AICL_VTH,
590590
RT9467_RANGE_AICL_VTH, aicl_vth);
591+
if (ret) {
592+
dev_err(data->dev, "Failed to set AICL VTH\n");
593+
return ret;
594+
}
591595

592596
/* Trigger AICL function */
593597
ret = regmap_field_write(data->rm_field[F_AICL_MEAS], 1);

0 commit comments

Comments
 (0)