Skip to content

Commit 8bb7d8e

Browse files
Mohsin Bashirkuba-moo
authored andcommitted
selftests: drv: net: avoid skipping tests
On a system with either of the ipv4 or ipv6 information missing, tests are currently skipped. Ideally, the test should run as long as at least one address family is present. This patch make test run whenever possible. Before: ./drivers/net/ping.py TAP version 13 1..6 ok 1 ping.test_default # SKIP Test requires IPv4 connectivity ok 2 ping.test_xdp_generic_sb # SKIP Test requires IPv4 connectivity ok 3 ping.test_xdp_generic_mb # SKIP Test requires IPv4 connectivity ok 4 ping.test_xdp_native_sb # SKIP Test requires IPv4 connectivity ok 5 ping.test_xdp_native_mb # SKIP Test requires IPv4 connectivity ok 6 ping.test_xdp_offload # SKIP device does not support offloaded XDP Totals: pass:0 fail:0 xfail:0 xpass:0 skip:6 error:0 After: ./drivers/net/ping.py TAP version 13 1..6 ok 1 ping.test_default ok 2 ping.test_xdp_generic_sb ok 3 ping.test_xdp_generic_mb ok 4 ping.test_xdp_native_sb ok 5 ping.test_xdp_native_mb ok 6 ping.test_xdp_offload # SKIP device does not support offloaded XDP Totals: pass:5 fail:0 xfail:0 xpass:0 skip:1 error:0 Fixes: 75cc19c ("selftests: drv-net: add xdp cases for ping.py") Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com> Link: https://patch.msgid.link/20250503013518.1722913-3-mohsin.bashr@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent b344a48 commit 8bb7d8e

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

  • tools/testing/selftests/drivers/net

tools/testing/selftests/drivers/net/ping.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,17 @@
1212
no_sleep=False
1313

1414
def _test_v4(cfg) -> None:
15-
cfg.require_ipver("4")
15+
if not cfg.addr_v["4"]:
16+
return
1617

1718
cmd("ping -c 1 -W0.5 " + cfg.remote_addr_v["4"])
1819
cmd("ping -c 1 -W0.5 " + cfg.addr_v["4"], host=cfg.remote)
1920
cmd("ping -s 65000 -c 1 -W0.5 " + cfg.remote_addr_v["4"])
2021
cmd("ping -s 65000 -c 1 -W0.5 " + cfg.addr_v["4"], host=cfg.remote)
2122

2223
def _test_v6(cfg) -> None:
23-
cfg.require_ipver("6")
24+
if not cfg.addr_v["6"]:
25+
return
2426

2527
cmd("ping -c 1 -W5 " + cfg.remote_addr_v["6"])
2628
cmd("ping -c 1 -W5 " + cfg.addr_v["6"], host=cfg.remote)

0 commit comments

Comments
 (0)