Skip to content

Commit 8c619eb

Browse files
oleremPaolo Abeni
authored andcommitted
net: phy: micrel: remove KSZ9477 EEE quirks now handled by phylink
The KSZ9477 PHY driver contained workarounds for broken EEE capability advertisements by manually masking supported EEE modes and forcibly disabling EEE if MICREL_NO_EEE was set. With proper MAC-side EEE handling implemented via phylink, these quirks are no longer necessary. Remove MICREL_NO_EEE handling and the use of ksz9477_get_features(). This simplifies the PHY driver and avoids duplicated EEE management logic. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Cc: stable@vger.kernel.org # v6.14+ Link: https://patch.msgid.link/20250504081434.424489-3-o.rempel@pengutronix.de Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent 76ca05e commit 8c619eb

2 files changed

Lines changed: 0 additions & 8 deletions

File tree

drivers/net/phy/micrel.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2027,12 +2027,6 @@ static int ksz9477_config_init(struct phy_device *phydev)
20272027
return err;
20282028
}
20292029

2030-
/* According to KSZ9477 Errata DS80000754C (Module 4) all EEE modes
2031-
* in this switch shall be regarded as broken.
2032-
*/
2033-
if (phydev->dev_flags & MICREL_NO_EEE)
2034-
phy_disable_eee(phydev);
2035-
20362030
return kszphy_config_init(phydev);
20372031
}
20382032

@@ -5705,7 +5699,6 @@ static struct phy_driver ksphy_driver[] = {
57055699
.handle_interrupt = kszphy_handle_interrupt,
57065700
.suspend = genphy_suspend,
57075701
.resume = ksz9477_resume,
5708-
.get_features = ksz9477_get_features,
57095702
} };
57105703

57115704
module_phy_driver(ksphy_driver);

include/linux/micrel_phy.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
#define MICREL_PHY_50MHZ_CLK BIT(0)
4545
#define MICREL_PHY_FXEN BIT(1)
4646
#define MICREL_KSZ8_P1_ERRATA BIT(2)
47-
#define MICREL_NO_EEE BIT(3)
4847

4948
#define MICREL_KSZ9021_EXTREG_CTRL 0xB
5049
#define MICREL_KSZ9021_EXTREG_DATA_WRITE 0xC

0 commit comments

Comments
 (0)