Skip to content

Commit 8c8b475

Browse files
olsajirianakryiko
authored andcommitted
libbpf: Fix uretprobe.multi.s programs auto attachment
As reported by Andrii we don't currently recognize uretprobe.multi.s programs as return probes due to using (wrong) strcmp function. Using str_has_pfx() instead to match uretprobe.multi prefix. Tests are passing, because the return program was executed as entry program and all counts were incremented properly. Reported-by: Andrii Nakryiko <andrii@kernel.org> Signed-off-by: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Link: https://lore.kernel.org/bpf/20240910125336.3056271-1-jolsa@kernel.org
1 parent 41d0c46 commit 8c8b475

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/lib/bpf/libbpf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11688,7 +11688,7 @@ static int attach_uprobe_multi(const struct bpf_program *prog, long cookie, stru
1168811688
ret = 0;
1168911689
break;
1169011690
case 3:
11691-
opts.retprobe = strcmp(probe_type, "uretprobe.multi") == 0;
11691+
opts.retprobe = str_has_pfx(probe_type, "uretprobe.multi");
1169211692
*link = bpf_program__attach_uprobe_multi(prog, -1, binary_path, func_name, &opts);
1169311693
ret = libbpf_get_error(*link);
1169411694
break;

0 commit comments

Comments
 (0)