Skip to content

Commit 8e3581f

Browse files
hoshinolinajannau
authored andcommitted
media: apple: isp: Option to use CMD_STOP (ifdeffed out)
Signed-off-by: Asahi Lina <lina@asahilina.net>
1 parent 5f8afbe commit 8e3581f

1 file changed

Lines changed: 17 additions & 2 deletions

File tree

  • drivers/media/platform/apple/isp

drivers/media/platform/apple/isp/isp-fw.c

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -595,11 +595,26 @@ static int isp_stop_command_processor(struct apple_isp *isp)
595595
{
596596
int retries;
597597

598+
#if 0
599+
int res = isp_cmd_stop(isp, 0);
600+
if (res) {
601+
isp_err(isp, "isp_cmd_stop() failed\n");
602+
return res;
603+
}
604+
598605
/* Wait for ISP_GPIO_0 to 0xf7fbdff9 -> 0x8042006 */
599606
isp_gpio_write32(isp, ISP_GPIO_0, 0xf7fbdff9);
600607

601-
/* Their CISP_CMD_STOP implementation is buggy */
602-
isp_cmd_suspend(isp);
608+
isp_cmd_power_down(isp);
609+
#else
610+
isp_gpio_write32(isp, ISP_GPIO_0, 0xf7fbdff9);
611+
612+
int res = isp_cmd_suspend(isp);
613+
if (res) {
614+
isp_err(isp, "isp_cmd_suspend() failed\n");
615+
return res;
616+
}
617+
#endif
603618

604619
for (retries = 0; retries < ISP_FIRMWARE_MAX_TRIES; retries++) {
605620
u32 val = isp_gpio_read32(isp, ISP_GPIO_0);

0 commit comments

Comments
 (0)