Skip to content

Commit 8fbdb8f

Browse files
ye xingchendtor
authored andcommitted
Input: synaptics-rmi4 - use sysfs_emit() to instead of scnprintf()
Replace calls to scnprintf() in the methods showing device attributes with sysfs_emit() to simplify the code. Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn> Link: https://lore.kernel.org/r/202212011551429834598@zte.com.cn Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent e50389f commit 8fbdb8f

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

drivers/input/rmi4/rmi_f01.c

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -267,8 +267,7 @@ static ssize_t rmi_driver_manufacturer_id_show(struct device *dev,
267267
struct rmi_driver_data *data = dev_get_drvdata(dev);
268268
struct f01_data *f01 = dev_get_drvdata(&data->f01_container->dev);
269269

270-
return scnprintf(buf, PAGE_SIZE, "%d\n",
271-
f01->properties.manufacturer_id);
270+
return sysfs_emit(buf, "%d\n", f01->properties.manufacturer_id);
272271
}
273272

274273
static DEVICE_ATTR(manufacturer_id, 0444,
@@ -280,7 +279,7 @@ static ssize_t rmi_driver_dom_show(struct device *dev,
280279
struct rmi_driver_data *data = dev_get_drvdata(dev);
281280
struct f01_data *f01 = dev_get_drvdata(&data->f01_container->dev);
282281

283-
return scnprintf(buf, PAGE_SIZE, "%s\n", f01->properties.dom);
282+
return sysfs_emit(buf, "%s\n", f01->properties.dom);
284283
}
285284

286285
static DEVICE_ATTR(date_of_manufacture, 0444, rmi_driver_dom_show, NULL);
@@ -292,7 +291,7 @@ static ssize_t rmi_driver_product_id_show(struct device *dev,
292291
struct rmi_driver_data *data = dev_get_drvdata(dev);
293292
struct f01_data *f01 = dev_get_drvdata(&data->f01_container->dev);
294293

295-
return scnprintf(buf, PAGE_SIZE, "%s\n", f01->properties.product_id);
294+
return sysfs_emit(buf, "%s\n", f01->properties.product_id);
296295
}
297296

298297
static DEVICE_ATTR(product_id, 0444, rmi_driver_product_id_show, NULL);
@@ -304,7 +303,7 @@ static ssize_t rmi_driver_firmware_id_show(struct device *dev,
304303
struct rmi_driver_data *data = dev_get_drvdata(dev);
305304
struct f01_data *f01 = dev_get_drvdata(&data->f01_container->dev);
306305

307-
return scnprintf(buf, PAGE_SIZE, "%d\n", f01->properties.firmware_id);
306+
return sysfs_emit(buf, "%d\n", f01->properties.firmware_id);
308307
}
309308

310309
static DEVICE_ATTR(firmware_id, 0444, rmi_driver_firmware_id_show, NULL);
@@ -318,8 +317,8 @@ static ssize_t rmi_driver_package_id_show(struct device *dev,
318317

319318
u32 package_id = f01->properties.package_id;
320319

321-
return scnprintf(buf, PAGE_SIZE, "%04x.%04x\n",
322-
package_id & 0xffff, (package_id >> 16) & 0xffff);
320+
return sysfs_emit(buf, "%04x.%04x\n",
321+
package_id & 0xffff, (package_id >> 16) & 0xffff);
323322
}
324323

325324
static DEVICE_ATTR(package_id, 0444, rmi_driver_package_id_show, NULL);

0 commit comments

Comments
 (0)