net: sched: em_text: fix possible memory leak in em_text_destroy()

HBh25Y · davem330 · commit 8fcb0382af6f · 2024-01-01T13:08:15.000Z
m->data needs to be freed when em_text_destroy is called. Fixes: d675c98 ("[PKT_SCHED]: Packet classification based on textsearch (ematch)") Acked-by: Jamal Hadi Salim <jhs@mojatatu.com> Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/sched/em_text.c b/net/sched/em_text.c
@@ -97,8 +97,10 @@ static int em_text_change(struct net *net, void *data, int len,
 
 static void em_text_destroy(struct tcf_ematch *m)
 {
-	if (EM_TEXT_PRIV(m) && EM_TEXT_PRIV(m)->config)
+	if (EM_TEXT_PRIV(m) && EM_TEXT_PRIV(m)->config) {
 		textsearch_destroy(EM_TEXT_PRIV(m)->config);
+		kfree(EM_TEXT_PRIV(m));
+	}
 }
 
 static int em_text_dump(struct sk_buff *skb, struct tcf_ematch *m)

Original file line number	Diff line number	Diff line change
`@@ -97,8 +97,10 @@ static int em_text_change(struct net net, void data, int len,`
`97`	`97`
`98`	`98`	`static void em_text_destroy(struct tcf_ematch *m)`
`99`	`99`	`{`
`100`		`- if (EM_TEXT_PRIV(m) && EM_TEXT_PRIV(m)->config)`
	`100`	`+ if (EM_TEXT_PRIV(m) && EM_TEXT_PRIV(m)->config) {`
`101`	`101`	`textsearch_destroy(EM_TEXT_PRIV(m)->config);`
	`102`	`+ kfree(EM_TEXT_PRIV(m));`
	`103`	`+ }`
`102`	`104`	`}`
`103`	`105`
`104`	`106`	`static int em_text_dump(struct sk_buff skb, struct tcf_ematch m)`