rtc: pcf8563: fix incorrect maximum clock rate handling

masneyb · alexandrebelloni · commit 906726a5efee · 2025-08-03T02:57:05.000+02:00
When pcf8563_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: a39a640 ("rtc: pcf8563: add CLKOUT to common clock framework") Signed-off-by: Brian Masney <bmasney@redhat.com> Link: https://lore.kernel.org/r/20250710-rtc-clk-round-rate-v1-5-33140bb2278e@redhat.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c
@@ -339,7 +339,7 @@ static long pcf8563_clkout_round_rate(struct clk_hw *hw, unsigned long rate,
 		if (clkout_rates[i] <= rate)
 			return clkout_rates[i];
 
-	return 0;
+	return clkout_rates[0];
 }
 
 static int pcf8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate,

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,7 @@ static long pcf8563_clkout_round_rate(struct clk_hw *hw, unsigned long rate,`
`339`	`339`	`if (clkout_rates[i] <= rate)`
`340`	`340`	`return clkout_rates[i];`
`341`	`341`
`342`		`- return 0;`
	`342`	`+ return clkout_rates[0];`
`343`	`343`	`}`
`344`	`344`
`345`	`345`	`static int pcf8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate,`