thermal: of: fix OF node leak in of_thermal_zone_find()

joehattori · rafaeljw · commit 9164e0912af2 · 2025-01-07T20:05:32.000+01:00
of_thermal_zone_find() calls of_parse_phandle_with_args(), but does not release the OF node reference obtained by it. Add a of_node_put() call when the call is successful. Fixes: 3fd6d6e ("thermal/of: Rework the thermal device tree initialization") Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp> Link: https://patch.msgid.link/20241224031809.950461-1-joe@pf.is.s.u-tokyo.ac.jp [ rjw: Changelog edit ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
@@ -160,6 +160,7 @@ static struct device_node *of_thermal_zone_find(struct device_node *sensor, int
 				return ERR_PTR(ret);
 			}
 
+			of_node_put(sensor_specs.np);
 			if ((sensor == sensor_specs.np) && id == (sensor_specs.args_count ?
 								  sensor_specs.args[0] : 0)) {
 				pr_debug("sensor %pOFn id=%d belongs to %pOFn\n", sensor, id, child);

Original file line number	Diff line number	Diff line change
`@@ -160,6 +160,7 @@ static struct device_node of_thermal_zone_find(struct device_node sensor, int`
`160`	`160`	`return ERR_PTR(ret);`
`161`	`161`	`}`
`162`	`162`
	`163`	`+ of_node_put(sensor_specs.np);`
`163`	`164`	`if ((sensor == sensor_specs.np) && id == (sensor_specs.args_count ?`
`164`	`165`	`sensor_specs.args[0] : 0)) {`
`165`	`166`	`pr_debug("sensor %pOFn id=%d belongs to %pOFn\n", sensor, id, child);`