PCI: sg2042: Fix a reference count issue in sg2042_pcie_remove()

tititiou36 · Mani-Sadhasivam · commit 932ec9dff6da · 2025-10-20T10:46:59.000+05:30
devm_pm_runtime_enable() is used in the probe, so pm_runtime_disable() should not be called explicitly in the remove function. Fixes: 1c72774 ("PCI: sg2042: Add Sophgo SG2042 PCIe driver") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org> Tested-by: Chen Wang <unicorn_wang@outlook.com> # on Pioneerbox. Acked-by: Chen Wang <unicorn_wang@outlook.com> Link: https://patch.msgid.link/242eca0ff6601de7966a53706e9950fbcb10aac8.1759169586.git.christophe.jaillet@wanadoo.fr
diff --git a/drivers/pci/controller/cadence/pcie-sg2042.c b/drivers/pci/controller/cadence/pcie-sg2042.c
@@ -74,15 +74,12 @@ static int sg2042_pcie_probe(struct platform_device *pdev)
 static void sg2042_pcie_remove(struct platform_device *pdev)
 {
 	struct cdns_pcie *pcie = platform_get_drvdata(pdev);
-	struct device *dev = &pdev->dev;
 	struct cdns_pcie_rc *rc;
 
 	rc = container_of(pcie, struct cdns_pcie_rc, pcie);
 	cdns_pcie_host_disable(rc);
 
 	cdns_pcie_disable_phy(pcie);
-
-	pm_runtime_disable(dev);
 }
 
 static int sg2042_pcie_suspend_noirq(struct device *dev)

Original file line number	Diff line number	Diff line change
`@@ -74,15 +74,12 @@ static int sg2042_pcie_probe(struct platform_device *pdev)`
`74`	`74`	`static void sg2042_pcie_remove(struct platform_device *pdev)`
`75`	`75`	`{`
`76`	`76`	`struct cdns_pcie *pcie = platform_get_drvdata(pdev);`
`77`		`- struct device *dev = &pdev->dev;`
`78`	`77`	`struct cdns_pcie_rc *rc;`
`79`	`78`
`80`	`79`	`rc = container_of(pcie, struct cdns_pcie_rc, pcie);`
`81`	`80`	`cdns_pcie_host_disable(rc);`
`82`	`81`
`83`	`82`	`cdns_pcie_disable_phy(pcie);`
`84`		`-`
`85`		`- pm_runtime_disable(dev);`
`86`	`83`	`}`
`87`	`84`
`88`	`85`	`static int sg2042_pcie_suspend_noirq(struct device *dev)`