drm: apple: av: Warn only once about failed calls

Reduce log spam while errors are still likely due missing state checks.

Author: jannau

drivers/gpu/drm/apple/av.c

@@ -59,6 +59,9 @@ struct audiosrv_data {
 	struct work_struct start_av_service_wq;
 
 	struct dcp_av_audio_cmds cmds;
+
+	bool warned_get_elements;
+	bool warned_get_product_attrs;
 };
 
 static void av_interface_init(struct apple_epic_service *service, const char *name,
@@ -207,10 +210,12 @@ int dcp_audiosrv_get_elements(struct device *dev, void *elements, size_t maxsize
 					 elements, maxsize, &size);
 	up_write(&asrv->srv_rwsem);
 
-	if (ret)
+	if (ret && asrv->warned_get_elements) {
 		dev_err(dev, "audiosrv: error getting elements: %d\n", ret);
-	else
+		asrv->warned_get_elements = true;
+	} else {
 		dev_dbg(dev, "audiosrv: got %zd bytes worth of elements\n", size);
+	}
 
 	return ret;
 }
@@ -228,10 +233,12 @@ int dcp_audiosrv_get_product_attrs(struct device *dev, void *attrs, size_t maxsi
 					 maxsize, &size);
 	up_write(&asrv->srv_rwsem);
 
-	if (ret)
+	if (ret && asrv->warned_get_product_attrs) {
 		dev_err(dev, "audiosrv: error getting product attributes: %d\n", ret);
-	else
+		asrv->warned_get_product_attrs = true;
+	} else {
 		dev_dbg(dev, "audiosrv: got %zd bytes worth of product attributes\n", size);
+	}
 
 	return ret;
 }