nouveau/firmware: Add missing kfree() of nvkm_falcon_fw::boot

covanam · Lyude · commit 949f1fd2225b · 2025-11-17T18:12:17.000-05:00
nvkm_falcon_fw::boot is allocated, but no one frees it. This causes a kmemleak warning. Make sure this data is deallocated. Fixes: 2541626 ("drm/nouveau/acr: use common falcon HS FW code for ACR FWs") Signed-off-by: Nam Cao <namcao@linutronix.de> Cc: stable@vger.kernel.org Reviewed-by: Lyude Paul <lyude@redhat.com> Signed-off-by: Lyude Paul <lyude@redhat.com> Link: https://patch.msgid.link/20251117084231.2910561-1-namcao@linutronix.de
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/fw.c b/drivers/gpu/drm/nouveau/nvkm/falcon/fw.c
@@ -159,6 +159,8 @@ nvkm_falcon_fw_dtor(struct nvkm_falcon_fw *fw)
 	nvkm_memory_unref(&fw->inst);
 	nvkm_falcon_fw_dtor_sigs(fw);
 	nvkm_firmware_dtor(&fw->fw);
+	kfree(fw->boot);
+	fw->boot = NULL;
 }
 
 static const struct nvkm_firmware_func

Original file line number	Diff line number	Diff line change
`@@ -159,6 +159,8 @@ nvkm_falcon_fw_dtor(struct nvkm_falcon_fw *fw)`
`159`	`159`	`nvkm_memory_unref(&fw->inst);`
`160`	`160`	`nvkm_falcon_fw_dtor_sigs(fw);`
`161`	`161`	`nvkm_firmware_dtor(&fw->fw);`
	`162`	`+ kfree(fw->boot);`
	`163`	`+ fw->boot = NULL;`
`162`	`164`	`}`
`163`	`165`
`164`	`166`	`static const struct nvkm_firmware_func`