Skip to content

Commit 94a7ce2

Browse files
committed
selftests/landlock: Fix readlink check
The audit_init_filter_exe() helper incorrectly checks the readlink(2) error because an unsigned integer is used to store the result. Use a signed integer for this check. Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/aDbFwyZ_fM-IO7sC@stanley.mountain Fixes: 6a500b2 ("selftests/landlock: Add tests for audit flags and domain IDs") Reviewed-by: Günther Noack <gnoack@google.com> Link: https://lore.kernel.org/r/20250528144426.1709063-1-mic@digikod.net Signed-off-by: Mickaël Salaün <mic@digikod.net>
1 parent e04c78d commit 94a7ce2

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

  • tools/testing/selftests/landlock

tools/testing/selftests/landlock/audit.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -403,11 +403,12 @@ static int audit_init_filter_exe(struct audit_filter *filter, const char *path)
403403
/* It is assume that there is not already filtering rules. */
404404
filter->record_type = AUDIT_EXE;
405405
if (!path) {
406-
filter->exe_len = readlink("/proc/self/exe", filter->exe,
407-
sizeof(filter->exe) - 1);
408-
if (filter->exe_len < 0)
406+
int ret = readlink("/proc/self/exe", filter->exe,
407+
sizeof(filter->exe) - 1);
408+
if (ret < 0)
409409
return -errno;
410410

411+
filter->exe_len = ret;
411412
return 0;
412413
}
413414

0 commit comments

Comments
 (0)