Skip to content

Commit 9615e01

Browse files
krzkwens
authored andcommitted
dt-bindings: arm: sunxi: Combine board variants into enums
The common style in all bindings for enumerating similar variants is to use 'enum', not 'oneOf', so all boards of same variant or using same SoM should be grouped under enum. It is more readable, more compact and makes easier to find actual devices from the same family/type. Also there is completely no point to repeat the compatible in the description (incircuit,icnova-a20-adb4006 implies this is "ICnova A20 ADB4006" and pine64,pinephone-1.2 implies "Pine64 PinePhone (1.2)"). Combine two easily visible cases: ICnova A20 and Pine64 PinePhone. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Chen-Yu Tsai <wens@csie.org> Link: https://patch.msgid.link/20250706095804.50475-2-krzysztof.kozlowski@linaro.org Signed-off-by: Chen-Yu Tsai <wens@csie.org>
1 parent de713cc commit 9615e01

1 file changed

Lines changed: 9 additions & 22 deletions

File tree

Documentation/devicetree/bindings/arm/sunxi.yaml

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -341,15 +341,11 @@ properties:
341341
- const: allwinner,i12-tvbox
342342
- const: allwinner,sun7i-a20
343343

344-
- description: ICnova A20 ADB4006
344+
- description: ICnova A20
345345
items:
346-
- const: incircuit,icnova-a20-adb4006
347-
- const: incircuit,icnova-a20
348-
- const: allwinner,sun7i-a20
349-
350-
- description: ICNova A20 SWAC
351-
items:
352-
- const: incircuit,icnova-a20-swac
346+
- enum:
347+
- incircuit,icnova-a20-adb4006
348+
- incircuit,icnova-a20-swac
353349
- const: incircuit,icnova-a20
354350
- const: allwinner,sun7i-a20
355351

@@ -760,21 +756,12 @@ properties:
760756
- const: pine64,pinebook
761757
- const: allwinner,sun50i-a64
762758

763-
- description: Pine64 PinePhone Developer Batch (1.0)
764-
items:
765-
- const: pine64,pinephone-1.0
766-
- const: pine64,pinephone
767-
- const: allwinner,sun50i-a64
768-
769-
- description: Pine64 PinePhone Braveheart (1.1)
770-
items:
771-
- const: pine64,pinephone-1.1
772-
- const: pine64,pinephone
773-
- const: allwinner,sun50i-a64
774-
775-
- description: Pine64 PinePhone (1.2)
759+
- description: Pine64 PinePhone
776760
items:
777-
- const: pine64,pinephone-1.2
761+
- enum:
762+
- pine64,pinephone-1.0 # Developer Batch (1.0)
763+
- pine64,pinephone-1.1 # Braveheart (1.1)
764+
- pine64,pinephone-1.2
778765
- const: pine64,pinephone
779766
- const: allwinner,sun50i-a64
780767

0 commit comments

Comments
 (0)