Skip to content

Commit 96a9178

Browse files
HoratiuVulturkuba-moo
authored andcommitted
net: phy: micrel: lan8814 fix reset of the QSGMII interface
The lan8814 is a quad-phy and it is using QSGMII towards the MAC. The problem is that everytime when one of the ports is configured then the PCS is reseted for all the PHYs. Meaning that the other ports can loose traffic until the link is establish again. To fix this, do the reset one time for the entire PHY package. Fixes: ece1950 ("net: phy: micrel: 1588 support for LAN8814 phy") Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Reviewed-by: Divya Koppera <Divya.Koppera@microchip.com > Link: https://patch.msgid.link/20251106090637.2030625-1-horatiu.vultur@microchip.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent ad17e7e commit 96a9178

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

drivers/net/phy/micrel.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4380,12 +4380,6 @@ static int lan8814_config_init(struct phy_device *phydev)
43804380
{
43814381
struct kszphy_priv *lan8814 = phydev->priv;
43824382

4383-
/* Reset the PHY */
4384-
lanphy_modify_page_reg(phydev, LAN8814_PAGE_COMMON_REGS,
4385-
LAN8814_QSGMII_SOFT_RESET,
4386-
LAN8814_QSGMII_SOFT_RESET_BIT,
4387-
LAN8814_QSGMII_SOFT_RESET_BIT);
4388-
43894383
/* Disable ANEG with QSGMII PCS Host side */
43904384
lanphy_modify_page_reg(phydev, LAN8814_PAGE_PORT_REGS,
43914385
LAN8814_QSGMII_PCS1G_ANEG_CONFIG,
@@ -4471,6 +4465,12 @@ static int lan8814_probe(struct phy_device *phydev)
44714465
addr, sizeof(struct lan8814_shared_priv));
44724466

44734467
if (phy_package_init_once(phydev)) {
4468+
/* Reset the PHY */
4469+
lanphy_modify_page_reg(phydev, LAN8814_PAGE_COMMON_REGS,
4470+
LAN8814_QSGMII_SOFT_RESET,
4471+
LAN8814_QSGMII_SOFT_RESET_BIT,
4472+
LAN8814_QSGMII_SOFT_RESET_BIT);
4473+
44744474
err = lan8814_release_coma_mode(phydev);
44754475
if (err)
44764476
return err;

0 commit comments

Comments
 (0)