Skip to content

Commit 9766096

Browse files
mistraubegregkh
authored andcommitted
staging: rtl8723bs: move rtw_handle_tkip_mic_err to rtw_recv.c
Move the function rtw_handle_tkip_mic_err from os_dep/recv_linux.c to core/rtw_recv.c to reduce code in the os_dep directory. Signed-off-by: Michael Straube <straube.linux@gmail.com> Reviewed-by: Hans de Goede <hansg@kernel.org> Link: https://lore.kernel.org/r/20250822135418.118115-4-straube.linux@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent f97151e commit 9766096

3 files changed

Lines changed: 44 additions & 46 deletions

File tree

drivers/staging/rtl8723bs/core/rtw_recv.c

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,50 @@ struct recv_buf *rtw_dequeue_recvbuf(struct __queue *queue)
294294

295295
}
296296

297+
static void rtw_handle_tkip_mic_err(struct adapter *padapter, u8 bgroup)
298+
{
299+
enum nl80211_key_type key_type = 0;
300+
union iwreq_data wrqu;
301+
struct iw_michaelmicfailure ev;
302+
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
303+
struct security_priv *psecuritypriv = &padapter->securitypriv;
304+
unsigned long cur_time = 0;
305+
306+
if (psecuritypriv->last_mic_err_time == 0) {
307+
psecuritypriv->last_mic_err_time = jiffies;
308+
} else {
309+
cur_time = jiffies;
310+
311+
if (cur_time - psecuritypriv->last_mic_err_time < 60*HZ) {
312+
psecuritypriv->btkip_countermeasure = true;
313+
psecuritypriv->last_mic_err_time = 0;
314+
psecuritypriv->btkip_countermeasure_time = cur_time;
315+
} else {
316+
psecuritypriv->last_mic_err_time = jiffies;
317+
}
318+
}
319+
320+
if (bgroup)
321+
key_type |= NL80211_KEYTYPE_GROUP;
322+
else
323+
key_type |= NL80211_KEYTYPE_PAIRWISE;
324+
325+
cfg80211_michael_mic_failure(padapter->pnetdev, (u8 *)&pmlmepriv->assoc_bssid[0], key_type, -1,
326+
NULL, GFP_ATOMIC);
327+
328+
memset(&ev, 0x00, sizeof(ev));
329+
if (bgroup)
330+
ev.flags |= IW_MICFAILURE_GROUP;
331+
else
332+
ev.flags |= IW_MICFAILURE_PAIRWISE;
333+
334+
ev.src_addr.sa_family = ARPHRD_ETHER;
335+
memcpy(ev.src_addr.sa_data, &pmlmepriv->assoc_bssid[0], ETH_ALEN);
336+
337+
memset(&wrqu, 0x00, sizeof(wrqu));
338+
wrqu.data.length = sizeof(ev);
339+
}
340+
297341
static signed int recvframe_chkmic(struct adapter *adapter, union recv_frame *precvframe)
298342
{
299343

drivers/staging/rtl8723bs/include/recv_osdep.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ extern void _rtw_free_recv_priv(struct recv_priv *precvpriv);
1515
extern s32 rtw_recv_entry(union recv_frame *precv_frame);
1616
extern void rtw_recv_returnpacket(struct net_device *cnxt, struct sk_buff *preturnedpkt);
1717

18-
extern void rtw_handle_tkip_mic_err(struct adapter *padapter, u8 bgroup);
19-
2018
int rtw_init_recv_priv(struct recv_priv *precvpriv, struct adapter *padapter);
2119
void rtw_free_recv_priv(struct recv_priv *precvpriv);
2220

drivers/staging/rtl8723bs/os_dep/recv_linux.c

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -135,47 +135,3 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, struct sk_buff *pkt, str
135135
rtw_netif_rx(padapter->pnetdev, pkt);
136136
}
137137
}
138-
139-
void rtw_handle_tkip_mic_err(struct adapter *padapter, u8 bgroup)
140-
{
141-
enum nl80211_key_type key_type = 0;
142-
union iwreq_data wrqu;
143-
struct iw_michaelmicfailure ev;
144-
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
145-
struct security_priv *psecuritypriv = &padapter->securitypriv;
146-
unsigned long cur_time = 0;
147-
148-
if (psecuritypriv->last_mic_err_time == 0) {
149-
psecuritypriv->last_mic_err_time = jiffies;
150-
} else {
151-
cur_time = jiffies;
152-
153-
if (cur_time - psecuritypriv->last_mic_err_time < 60*HZ) {
154-
psecuritypriv->btkip_countermeasure = true;
155-
psecuritypriv->last_mic_err_time = 0;
156-
psecuritypriv->btkip_countermeasure_time = cur_time;
157-
} else {
158-
psecuritypriv->last_mic_err_time = jiffies;
159-
}
160-
}
161-
162-
if (bgroup)
163-
key_type |= NL80211_KEYTYPE_GROUP;
164-
else
165-
key_type |= NL80211_KEYTYPE_PAIRWISE;
166-
167-
cfg80211_michael_mic_failure(padapter->pnetdev, (u8 *)&pmlmepriv->assoc_bssid[0], key_type, -1,
168-
NULL, GFP_ATOMIC);
169-
170-
memset(&ev, 0x00, sizeof(ev));
171-
if (bgroup)
172-
ev.flags |= IW_MICFAILURE_GROUP;
173-
else
174-
ev.flags |= IW_MICFAILURE_PAIRWISE;
175-
176-
ev.src_addr.sa_family = ARPHRD_ETHER;
177-
memcpy(ev.src_addr.sa_data, &pmlmepriv->assoc_bssid[0], ETH_ALEN);
178-
179-
memset(&wrqu, 0x00, sizeof(wrqu));
180-
wrqu.data.length = sizeof(ev);
181-
}

0 commit comments

Comments
 (0)