drm: nouveau: Replace sprintf() with sysfs_emit()

MadhurKumar004 · Lyude · commit 979e2ec58de2 · 2025-12-05T15:15:40.000-05:00
Replace sprintf() calls with sysfs_emit() to follow current kernel coding standards. sysfs_emit() is the preferred method for formatting sysfs output as it provides better bounds checking and is more secure. Signed-off-by: Madhur Kumar <madhurkumar004@gmail.com> Reviewed-by: Lyude Paul <lyude@redhat.com> Signed-off-by: Lyude Paul <lyude@redhat.com> Link: https://patch.msgid.link/20251205091804.317801-1-madhurkumar004@gmail.com Fixes: 11b7d89 ("drm/nouveau/pm: manual pwm fanspeed management for nv40+ boards") Cc: <stable@vger.kernel.org> # v3.3+
diff --git a/drivers/gpu/drm/nouveau/nouveau_hwmon.c b/drivers/gpu/drm/nouveau/nouveau_hwmon.c
@@ -125,7 +125,7 @@ nouveau_hwmon_get_pwm1_max(struct device *d,
 	if (ret < 0)
 		return ret;
 
-	return sprintf(buf, "%i\n", ret);
+	return sysfs_emit(buf, "%i\n", ret);
 }
 
 static ssize_t
@@ -141,7 +141,7 @@ nouveau_hwmon_get_pwm1_min(struct device *d,
 	if (ret < 0)
 		return ret;
 
-	return sprintf(buf, "%i\n", ret);
+	return sysfs_emit(buf, "%i\n", ret);
 }
 
 static ssize_t

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ nouveau_hwmon_get_pwm1_max(struct device *d,`
`125`	`125`	`if (ret < 0)`
`126`	`126`	`return ret;`
`127`	`127`
`128`		`- return sprintf(buf, "%i\n", ret);`
	`128`	`+ return sysfs_emit(buf, "%i\n", ret);`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`static ssize_t`
`@@ -141,7 +141,7 @@ nouveau_hwmon_get_pwm1_min(struct device *d,`
`141`	`141`	`if (ret < 0)`
`142`	`142`	`return ret;`
`143`	`143`
`144`		`- return sprintf(buf, "%i\n", ret);`
	`144`	`+ return sysfs_emit(buf, "%i\n", ret);`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`static ssize_t`