drm/gem-atomic: Reset plane state to NULL if allocation failed

tdz · tdz · commit 9837f9fcb7eb · 2025-10-26T17:12:58.000+01:00
Unconditionally reset plane->state to NULL if the allocation of the shadow plane state fails. Avoids an invalid address in the field. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Link: https://patch.msgid.link/20251017091919.58770-1-tzimmermann@suse.de
diff --git a/drivers/gpu/drm/drm_gem_atomic_helper.c b/drivers/gpu/drm/drm_gem_atomic_helper.c
@@ -334,8 +334,6 @@ void drm_gem_reset_shadow_plane(struct drm_plane *plane)
 	}
 
 	shadow_plane_state = kzalloc(sizeof(*shadow_plane_state), GFP_KERNEL);
-	if (!shadow_plane_state)
-		return;
 	__drm_gem_reset_shadow_plane(plane, shadow_plane_state);
 }
 EXPORT_SYMBOL(drm_gem_reset_shadow_plane);

Original file line number	Diff line number	Diff line change
`@@ -334,8 +334,6 @@ void drm_gem_reset_shadow_plane(struct drm_plane *plane)`
`334`	`334`	`}`
`335`	`335`
`336`	`336`	`shadow_plane_state = kzalloc(sizeof(*shadow_plane_state), GFP_KERNEL);`
`337`		`- if (!shadow_plane_state)`
`338`		`- return;`
`339`	`337`	`__drm_gem_reset_shadow_plane(plane, shadow_plane_state);`
`340`	`338`	`}`
`341`	`339`	`EXPORT_SYMBOL(drm_gem_reset_shadow_plane);`