Skip to content

Commit 9963327

Browse files
committed
Merge tag 'fs_for_v6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
Pull small quota cleanup from Jan Kara. * tag 'fs_for_v6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs: quota: convert dquot_claim_space_nodirty() to return void
2 parents ab27740 + d1c3710 commit 9963327

2 files changed

Lines changed: 8 additions & 13 deletions

File tree

fs/quota/dquot.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1787,7 +1787,7 @@ EXPORT_SYMBOL(dquot_alloc_inode);
17871787
/*
17881788
* Convert in-memory reserved quotas to real consumed quotas
17891789
*/
1790-
int dquot_claim_space_nodirty(struct inode *inode, qsize_t number)
1790+
void dquot_claim_space_nodirty(struct inode *inode, qsize_t number)
17911791
{
17921792
struct dquot **dquots;
17931793
int cnt, index;
@@ -1797,7 +1797,7 @@ int dquot_claim_space_nodirty(struct inode *inode, qsize_t number)
17971797
*inode_reserved_space(inode) -= number;
17981798
__inode_add_bytes(inode, number);
17991799
spin_unlock(&inode->i_lock);
1800-
return 0;
1800+
return;
18011801
}
18021802

18031803
dquots = i_dquot(inode);
@@ -1822,7 +1822,7 @@ int dquot_claim_space_nodirty(struct inode *inode, qsize_t number)
18221822
spin_unlock(&inode->i_lock);
18231823
mark_all_dquot_dirty(dquots);
18241824
srcu_read_unlock(&dquot_srcu, index);
1825-
return 0;
1825+
return;
18261826
}
18271827
EXPORT_SYMBOL(dquot_claim_space_nodirty);
18281828

include/linux/quotaops.h

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ void __dquot_free_space(struct inode *inode, qsize_t number, int flags);
7474

7575
int dquot_alloc_inode(struct inode *inode);
7676

77-
int dquot_claim_space_nodirty(struct inode *inode, qsize_t number);
77+
void dquot_claim_space_nodirty(struct inode *inode, qsize_t number);
7878
void dquot_free_inode(struct inode *inode);
7979
void dquot_reclaim_space_nodirty(struct inode *inode, qsize_t number);
8080

@@ -257,10 +257,9 @@ static inline void __dquot_free_space(struct inode *inode, qsize_t number,
257257
inode_sub_bytes(inode, number);
258258
}
259259

260-
static inline int dquot_claim_space_nodirty(struct inode *inode, qsize_t number)
260+
static inline void dquot_claim_space_nodirty(struct inode *inode, qsize_t number)
261261
{
262262
inode_add_bytes(inode, number);
263-
return 0;
264263
}
265264

266265
static inline int dquot_reclaim_space_nodirty(struct inode *inode,
@@ -358,14 +357,10 @@ static inline int dquot_reserve_block(struct inode *inode, qsize_t nr)
358357
DQUOT_SPACE_WARN|DQUOT_SPACE_RESERVE);
359358
}
360359

361-
static inline int dquot_claim_block(struct inode *inode, qsize_t nr)
360+
static inline void dquot_claim_block(struct inode *inode, qsize_t nr)
362361
{
363-
int ret;
364-
365-
ret = dquot_claim_space_nodirty(inode, nr << inode->i_blkbits);
366-
if (!ret)
367-
mark_inode_dirty_sync(inode);
368-
return ret;
362+
dquot_claim_space_nodirty(inode, nr << inode->i_blkbits);
363+
mark_inode_dirty_sync(inode);
369364
}
370365

371366
static inline void dquot_reclaim_block(struct inode *inode, qsize_t nr)

0 commit comments

Comments
 (0)