Skip to content

Commit 999fb9d

Browse files
lweiss-fairphonebroonie
authored andcommitted
ASoC: qcom: sm8250: Fix possibly undefined reference
With CONFIG_SND_SOC_SM8250=y and CONFIG_SND_SOC_QCOM_OFFLOAD_UTILS=m selected in kconfig, the build will fail due to trying to link against a symbol only found in the module. aarch64-linux-gnu-ld: sound/soc/qcom/sm8250.o: in function `sm8250_snd_exit': sound/soc/qcom/sm8250.c:52:(.text+0x210): undefined reference to `qcom_snd_usb_offload_jack_remove' Fix this by declaring the dependency that forces CONFIG_SND_SOC_SM8250=m when CONFIG_SND_SOC_QCOM_OFFLOAD_UTILS is =m. Reported-by: Matthew Croughan <matthew.croughan@nix.how> Fixes: 1b8d0d8 ("ASoC: qcom: qdsp6: Add headphone jack for offload connection status") Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Link: https://patch.msgid.link/20250617-snd-sm8250-dep-fix-v1-1-879af8906ec4@fairphone.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 86731a2 commit 999fb9d

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

sound/soc/qcom/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,7 @@ config SND_SOC_SM8250
186186
tristate "SoC Machine driver for SM8250 boards"
187187
depends on QCOM_APR && SOUNDWIRE
188188
depends on COMMON_CLK
189+
depends on SND_SOC_QCOM_OFFLOAD_UTILS || !SND_SOC_QCOM_OFFLOAD_UTILS
189190
select SND_SOC_QDSP6
190191
select SND_SOC_QCOM_COMMON
191192
select SND_SOC_QCOM_SDW

0 commit comments

Comments
 (0)