Skip to content

Commit 99a157d

Browse files
svenpeter42jannau
authored andcommitted
phy: apple: atc: Reset USB2 PHY during probe as well
Now that the upstream Type-C PHY code is getting wider testing we got reports of USB devices plugged in during boot or those plugged in for the first time after boot occasionally not working correctly. This seems to be caused by the USB2 parts of the PHY being left in an unknown state by the previous boot stages. We reset all other parts during probe but forgot about the USB2 PHY so let's fix that and actually reset and power off everything. Reported-by: James Calligeros <jcalligeros99@gmail.com> Reported-by: Janne Grunau <j@jannau.net> Fixes: 8e98ca1 ("phy: apple: Add Apple Type-C PHY") Signed-off-by: Sven Peter <sven@kernel.org>
1 parent d078f16 commit 99a157d

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/phy/apple/atc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2227,6 +2227,7 @@ static int atcphy_probe_finalize(struct apple_atcphy *atcphy)
22272227
_atcphy_dwc3_reset_assert(atcphy);
22282228

22292229
/* Reset atcphy to clear any state potentially left by the bootloader */
2230+
atcphy_usb2_power_off(atcphy);
22302231
atcphy_power_off(atcphy);
22312232
atcphy_setup_pipehandler(atcphy);
22322233

0 commit comments

Comments
 (0)