Skip to content

Commit 9b23417

Browse files
dtatuleamstsirkin
authored andcommitted
vdpa/mlx5: Mark vq addrs for modification in hw vq
Addresses get set by .set_vq_address. hw vq addresses will be updated on next modify_virtqueue. Reviewed-by: Gal Pressman <gal@nvidia.com> Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com> Message-Id: <20231225151203.152687-5-dtatulea@nvidia.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
1 parent 1450969 commit 9b23417

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

drivers/vdpa/mlx5/net/mlx5_vnet.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1209,6 +1209,7 @@ static int modify_virtqueue(struct mlx5_vdpa_net *ndev,
12091209
bool state_change = false;
12101210
void *obj_context;
12111211
void *cmd_hdr;
1212+
void *vq_ctx;
12121213
void *in;
12131214
int err;
12141215

@@ -1230,6 +1231,7 @@ static int modify_virtqueue(struct mlx5_vdpa_net *ndev,
12301231
MLX5_SET(general_obj_in_cmd_hdr, cmd_hdr, uid, ndev->mvdev.res.uid);
12311232

12321233
obj_context = MLX5_ADDR_OF(modify_virtio_net_q_in, in, obj_context);
1234+
vq_ctx = MLX5_ADDR_OF(virtio_net_q_object, obj_context, virtio_q_context);
12331235

12341236
if (mvq->modified_fields & MLX5_VIRTQ_MODIFY_MASK_STATE) {
12351237
if (!is_valid_state_change(mvq->fw_state, state, is_resumable(ndev))) {
@@ -1241,6 +1243,12 @@ static int modify_virtqueue(struct mlx5_vdpa_net *ndev,
12411243
state_change = true;
12421244
}
12431245

1246+
if (mvq->modified_fields & MLX5_VIRTQ_MODIFY_MASK_VIRTIO_Q_ADDRS) {
1247+
MLX5_SET64(virtio_q, vq_ctx, desc_addr, mvq->desc_addr);
1248+
MLX5_SET64(virtio_q, vq_ctx, used_addr, mvq->device_addr);
1249+
MLX5_SET64(virtio_q, vq_ctx, available_addr, mvq->driver_addr);
1250+
}
1251+
12441252
MLX5_SET64(virtio_net_q_object, obj_context, modify_field_select, mvq->modified_fields);
12451253
err = mlx5_cmd_exec(ndev->mvdev.mdev, in, inlen, out, sizeof(out));
12461254
if (err)
@@ -2202,6 +2210,7 @@ static int mlx5_vdpa_set_vq_address(struct vdpa_device *vdev, u16 idx, u64 desc_
22022210
mvq->desc_addr = desc_area;
22032211
mvq->device_addr = device_area;
22042212
mvq->driver_addr = driver_area;
2213+
mvq->modified_fields |= MLX5_VIRTQ_MODIFY_MASK_VIRTIO_Q_ADDRS;
22052214
return 0;
22062215
}
22072216

include/linux/mlx5/mlx5_ifc_vdpa.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ enum {
145145
MLX5_VIRTQ_MODIFY_MASK_STATE = (u64)1 << 0,
146146
MLX5_VIRTQ_MODIFY_MASK_DIRTY_BITMAP_PARAMS = (u64)1 << 3,
147147
MLX5_VIRTQ_MODIFY_MASK_DIRTY_BITMAP_DUMP_ENABLE = (u64)1 << 4,
148+
MLX5_VIRTQ_MODIFY_MASK_VIRTIO_Q_ADDRS = (u64)1 << 6,
148149
MLX5_VIRTQ_MODIFY_MASK_DESC_GROUP_MKEY = (u64)1 << 14,
149150
};
150151

0 commit comments

Comments
 (0)