Skip to content

Commit 9bf9f98

Browse files
committed
fbdev/pxafb: Unexport symbol
Fix the compile-time warning drivers/video/fbdev/pxafb.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing The affected symbol is not used anywhere, so remove the function entirely. v2: - remove unused functions (Helge) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Helge Deller <deller@gmx.de> Fixes: a934a57 ("scripts/misc-check: check missing #include <linux/export.h> when W=1") Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Nathan Chancellor <nathan@kernel.org> Link: https://lore.kernel.org/r/20250612081738.197826-12-tzimmermann@suse.de
1 parent a278863 commit 9bf9f98

2 files changed

Lines changed: 2 additions & 16 deletions

File tree

drivers/video/fbdev/pxafb.c

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1030,9 +1030,8 @@ static inline unsigned int get_pcd(struct pxafb_info *fbi,
10301030

10311031
/*
10321032
* Some touchscreens need hsync information from the video driver to
1033-
* function correctly. We export it here. Note that 'hsync_time' and
1034-
* the value returned from pxafb_get_hsync_time() is the *reciprocal*
1035-
* of the hsync period in seconds.
1033+
* function correctly. We export it here. Note that 'hsync_time' is
1034+
* the *reciprocal* of the hsync period in seconds.
10361035
*/
10371036
static inline void set_hsync_time(struct pxafb_info *fbi, unsigned int pcd)
10381037
{
@@ -1048,18 +1047,6 @@ static inline void set_hsync_time(struct pxafb_info *fbi, unsigned int pcd)
10481047
fbi->hsync_time = htime;
10491048
}
10501049

1051-
unsigned long pxafb_get_hsync_time(struct device *dev)
1052-
{
1053-
struct pxafb_info *fbi = dev_get_drvdata(dev);
1054-
1055-
/* If display is blanked/suspended, hsync isn't active */
1056-
if (!fbi || (fbi->state != C_ENABLE))
1057-
return 0;
1058-
1059-
return fbi->hsync_time;
1060-
}
1061-
EXPORT_SYMBOL(pxafb_get_hsync_time);
1062-
10631050
static int setup_frame_dma(struct pxafb_info *fbi, int dma, int pal,
10641051
unsigned long start, size_t size)
10651052
{

include/linux/platform_data/video-pxafb.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ struct pxafb_mach_info {
150150
};
151151

152152
void pxa_set_fb_info(struct device *, struct pxafb_mach_info *);
153-
unsigned long pxafb_get_hsync_time(struct device *dev);
154153

155154
/* smartpanel related */
156155
#define SMART_CMD_A0 (0x1 << 8)

0 commit comments

Comments
 (0)