Skip to content

Commit 9dca7a0

Browse files
Chen NiWim Van Sebroeck
authored andcommitted
watchdog: starfive: Add missing clk_disable_unprepare()
Add the missing clk_disable_unprepare() before return in starfive_wdt_enable_clock(). Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Reviewed-by: Xingyu Wu <xingyu.wu@starfivetech.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20240628033508.281058-1-nichen@iscas.ac.cn Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
1 parent d794a74 commit 9dca7a0

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/watchdog/starfive-wdt.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,10 @@ static int starfive_wdt_enable_clock(struct starfive_wdt *wdt)
152152
return dev_err_probe(wdt->wdd.parent, ret, "failed to enable apb clock\n");
153153

154154
ret = clk_prepare_enable(wdt->core_clk);
155-
if (ret)
155+
if (ret) {
156+
clk_disable_unprepare(wdt->apb_clk);
156157
return dev_err_probe(wdt->wdd.parent, ret, "failed to enable core clock\n");
158+
}
157159

158160
return 0;
159161
}

0 commit comments

Comments
 (0)