Skip to content

Commit a00e15f

Browse files
jhnikulaalexandrebelloni
authored andcommitted
i3c: mipi-i3c-hci: Remove function enter DBG() printouts
These function enter DBG("") printouts are not very useful in error report point of view because they require code recompile. In which case they can be replaced with more informative debug prints if needed so remove them for now. Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Link: https://lore.kernel.org/r/20250827103009.243771-5-jarkko.nikula@linux.intel.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 4470c85 commit a00e15f

1 file changed

Lines changed: 0 additions & 16 deletions

File tree

  • drivers/i3c/master/mipi-i3c-hci

drivers/i3c/master/mipi-i3c-hci/core.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,6 @@ static int i3c_hci_bus_init(struct i3c_master_controller *m)
121121
struct i3c_device_info info;
122122
int ret;
123123

124-
DBG("");
125-
126124
if (hci->cmd == &mipi_i3c_hci_cmd_v1) {
127125
ret = mipi_i3c_hci_dat_v1.init(hci);
128126
if (ret)
@@ -159,8 +157,6 @@ static void i3c_hci_bus_cleanup(struct i3c_master_controller *m)
159157
struct i3c_hci *hci = to_i3c_hci(m);
160158
struct platform_device *pdev = to_platform_device(m->dev.parent);
161159

162-
DBG("");
163-
164160
reg_clear(HC_CONTROL, HC_CONTROL_BUS_ENABLE);
165161
synchronize_irq(platform_get_irq(pdev, 0));
166162
hci->io->cleanup(hci);
@@ -267,8 +263,6 @@ static int i3c_hci_daa(struct i3c_master_controller *m)
267263
{
268264
struct i3c_hci *hci = to_i3c_hci(m);
269265

270-
DBG("");
271-
272266
return hci->cmd->perform_daa(hci);
273267
}
274268

@@ -385,8 +379,6 @@ static int i3c_hci_attach_i3c_dev(struct i3c_dev_desc *dev)
385379
struct i3c_hci_dev_data *dev_data;
386380
int ret;
387381

388-
DBG("");
389-
390382
dev_data = kzalloc(sizeof(*dev_data), GFP_KERNEL);
391383
if (!dev_data)
392384
return -ENOMEM;
@@ -410,8 +402,6 @@ static int i3c_hci_reattach_i3c_dev(struct i3c_dev_desc *dev, u8 old_dyn_addr)
410402
struct i3c_hci *hci = to_i3c_hci(m);
411403
struct i3c_hci_dev_data *dev_data = i3c_dev_get_master_data(dev);
412404

413-
DBG("");
414-
415405
if (hci->cmd == &mipi_i3c_hci_cmd_v1)
416406
mipi_i3c_hci_dat_v1.set_dynamic_addr(hci, dev_data->dat_idx,
417407
dev->info.dyn_addr);
@@ -424,8 +414,6 @@ static void i3c_hci_detach_i3c_dev(struct i3c_dev_desc *dev)
424414
struct i3c_hci *hci = to_i3c_hci(m);
425415
struct i3c_hci_dev_data *dev_data = i3c_dev_get_master_data(dev);
426416

427-
DBG("");
428-
429417
i3c_dev_set_master_data(dev, NULL);
430418
if (hci->cmd == &mipi_i3c_hci_cmd_v1)
431419
mipi_i3c_hci_dat_v1.free_entry(hci, dev_data->dat_idx);
@@ -439,8 +427,6 @@ static int i3c_hci_attach_i2c_dev(struct i2c_dev_desc *dev)
439427
struct i3c_hci_dev_data *dev_data;
440428
int ret;
441429

442-
DBG("");
443-
444430
if (hci->cmd != &mipi_i3c_hci_cmd_v1)
445431
return 0;
446432
dev_data = kzalloc(sizeof(*dev_data), GFP_KERNEL);
@@ -464,8 +450,6 @@ static void i3c_hci_detach_i2c_dev(struct i2c_dev_desc *dev)
464450
struct i3c_hci *hci = to_i3c_hci(m);
465451
struct i3c_hci_dev_data *dev_data = i2c_dev_get_master_data(dev);
466452

467-
DBG("");
468-
469453
if (dev_data) {
470454
i2c_dev_set_master_data(dev, NULL);
471455
if (hci->cmd == &mipi_i3c_hci_cmd_v1)

0 commit comments

Comments
 (0)